Giter Site home page Giter Site logo

Comments (3)

orottier avatar orottier commented on May 22, 2024

Hey, thanks for thinking along, it's much appreciated. I think you have summarized the three cases very well.

I fully agree with 1) The alloc/AudioBuffer should be named better to avoid confusion with the user facing AudioBuffers. alloc is a really bad mod name too. There should probably be a render mod containing the Graph, AudioProcessor and the new AudioRenderQuantum

I'm interested to hear your proposal for a distinction of 2 and 3.
In my eyes, a memory resident buffer is the buffer::AudioBuffer and anything that acts as a continuous source of audio is an Iterator<Item=AudioBuffer>.
For example, if you decode an Ogg Vorbis file, you receive chunks of audio, fitting this iterator style. Decoding a wav (currently) works sample-for-sample so we just take BUFFER_SIZEd chunks.

In any case, please let me know what you intend to refactor. We can surely work out something that is better than the current state

from web-audio-api-rs.

b-ma avatar b-ma commented on May 22, 2024

Ok cool, thanks for your answer. What I can imagine to advance on that is:

  • First, make a PR with the renaming stuff and file reorganisation, which is only refactoring and should not impact any behaviour.
  • For the rest, I really think it's feasible to work on something focusing on 2. alongside the existing code and without interfering with the other modules and tests. Then, if I manage to make something work at some point, we can just discuss / amend the result, and eventually see how to integrate it properly.

Sounds like a plan?

from web-audio-api-rs.

orottier avatar orottier commented on May 22, 2024

Sounds good to me!

from web-audio-api-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.