Giter Site home page Giter Site logo

Comments (2)

james-d-elliott avatar james-d-elliott commented on June 3, 2024

Simple String Comparison is the current best security practice in OAuth 2.0 and is the requirement in the OpenID Connect 1.0 standard, as well as the upcoming OAuth 2.1 standard it's (likely but it's not published yet) becoming a requirement similar to in OpenID Connect 1.0. As such it's probably "most correct" to specifically look at what Simple String Comparison actually means. Syntax Based Normalization from what I can see is a different string comparison type.

Edit: For these reasons I'd argue that fosite is actually following the spec accurately, and the client implementations should normalize the redirect_uri prior to making the request or during the configuration provisioning steps. I do however wonder if there is merit in adding a method to the configurator that returns the redirect uri matching func as it may be useful in other scenarios which are not traditionally compliant.

RFC3986 Section 6.2 is the comparison ladder, but neither the OAuth 2.0 Current Best Practices, OAuth 2.1, or OpenID Connect 1.0 mention use of this comparison ladder; just the use of the singular comparison type within the ladder.

from fosite.

aeneasr avatar aeneasr commented on June 3, 2024

Thanks James, I agree with that. It's also mandated by the conformity test suite. Closing

from fosite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.