Comments (5)
So, if I read this correctly, the pod fails because it doesn't recognise dsn as being set. In your values.yaml you dont specify the dsn in the config, not supply it as an env. The issue i think comes from here https://github.com/ory/k8s/blob/master/helm/charts/kratos/templates/deployment-kratos.yaml#L151 between the interaction of a user supplied dsn vs external secret 🤔
from k8s.
Actually, it fails even before that, it fails here
. I'm not sure if the deployment would work, as it did not get past automigration but I assume the result would be same.Just to note, this is an existing setup, what is failing is not new install, it's the upgrade.
But overall, yes, you are correct. I'm supplying secret externally and referring to it through secret.nameOverride
, until now, that was working, because there was no check for emptiness on dsn in config. Now, with that check there, I need to set dsn to whatever
.
Of course, it's not a big issue, I've just set dsn
to whatever
in my values.yaml
and it works again, but I'm not sure if that's the intent here 😄
from k8s.
Just one more note, in default values.yaml
there's this:
k8s/helm/charts/kratos/values.yaml
Line 82 in 598c91b
Which I think implies that it's meant to be used the way I've used it? 🤔 Unless I've misread that comment 🤔
from k8s.
No, you understand correctly :) Those two options are there to support similar use cases:
- The secretnameOverride allows you to use an existing secret that is sideloaded with the chart
- The Env overrides allows for more customization like construction of the DSN from envs injected into the system at runtime, or even supporting different dsn for the main application and for example courier (you can set different connection parameters for them, as by default they would reuse the same dsn string)
I would say this is a small (as there is a simple workaround as you noticed) regression that we need to address in the upgrade pipeline 🤔
from k8s.
Hi there! I pushed a fix to the generation logic, could you please verify from the master version if your case is supported properly? I updated the test cases to cover more options, and it looks ok, but would like real user feedback before making the next release 😉
from k8s.
Related Issues (20)
- Inconsistency with service account annotations on maester charts
- OathKeeper Default Helm Chart Issue | Pod throwing 503. HOT 11
- Extend Test Helm Charts for Hydra, Keto and Oathkeeper to allow user defined labels for test pod HOT 1
- Warning when setting a namespaces location in keto HOT 3
- deploy image of oathkeeper-maester to arm64 HOT 4
- Helm Chart Missing Keto Link
- failed to download "https://k8s.ory.sh/helm/charts/kratos-0.36.0.tgz" at version "0.36.0" HOT 1
- Unable to rotate secretsCookie in k8s helm chart HOT 1
- 0.37 release is wrongly numbered HOT 1
- Hydra helm chart values miss hydra.config examples. HOT 2
- Hydra Maester chart does not allow env variables, but maester v0.0.31 requires it
- Kratos selfservice UI incorrectly supports `BASE_PATH`
- Ory hydra dsn configuration through existing secret causes env var to not be defined HOT 2
- DSN environmental variable is not set optionally HOT 2
- Unable to use NodePort while deploying kratos and kratos-selfservice-ui-node helm charts
- Cannot "inject" values for email templates from files HOT 5
- support hooks HOT 2
- Allow DSN to retrieved some a separate secret HOT 4
- config.courier.template_override_path not used.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from k8s.