Giter Site home page Giter Site logo

Comments (7)

neilboyd avatar neilboyd commented on July 24, 2024

Fixed in commit 22677d6

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

I think 22677d6 is a bad idea and it will crash. If we start to use longs in MapSize() that means we support a much larger map size - one that Android's canvas does not support since it uses integers for its coordinate system. I suspect that this will break if you zoom in far and travel to the edges of the map. Also it doesn't compile with Java 8 since it appears that implicit conversions from long to int are errors now (I think that's what is happening to me).

from osmdroid.

neilboyd avatar neilboyd commented on July 24, 2024

What should we do instead? Argument check to prevent tiles larger than 256?

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

I think I need to take some time to reproduce and explore the problem more, but calling TileSystem.setTileSize(512) might be all that is needed. Can OP try that and confirm?

I think most people are interested in scaling the tiles to the device's dpi which is why they are doing this (it has been proposed as a sort-of-working solution for that). Maybe that's the real problem to solve.

from osmdroid.

ziem avatar ziem commented on July 24, 2024

I think most people are interested in scaling the tiles to the device's dpi which is why they are doing this (it has been proposed as a sort-of-working solution for that). Maybe that's the real problem to solve.

I agree! Tiles are too small on high dpi devices like Nexus 5 and posted workaround:
#49 (comment)
is causing problems:
#13
#68

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

Please take a look at #81 where we have a potential solution ready for testing.

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

I have merged the fix_dpi_scaling branch. Call mMapView.setTilesScaledToDpi(true) to turn on tile scaling. Report all issues to #81.

from osmdroid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.