Comments (10)
The change to onLayout is a bit out of date because of the recent projection changes.
All the code in scrollTo is also missing.
Please could you supply a patch to MapView with just the changes required to fix this issue.
from osmdroid.
Effectively, the change was obsolete with those changes.
I updated the fix according to osmdroid 4.2 changes.
Here is the patched MapView: https://drive.google.com/file/d/0B_8VOmRyW664WGotcmRLbjV3TDA/edit?usp=sharing
See sections marked with "ADDED" / "END".
- EDIT on 30/05 -
Hi Neil,
Any chance to have this fixed soon?
I see that you are busy with Xamarin project, but integrating the patch should be pretty straightforward.
from osmdroid.
Neil, Marc,
Any chance to have this fix integrated in the next version of osmdroid?
(currently, bubbles are unusable when the map is rotated - this is a big drawback)
from osmdroid.
Any tests on how calling onLayout on every scroll affects performance? That is the only thing that gives me pause. Actually - how are we getting away with not having to do that now?
from osmdroid.
Okay - we don't have to do that now because we use mercator projection (regular canvas) coordinates to set the position. I don't think calling onLayout will affect performance that much, but I'd like to confirm that before committing. This is an important patch and we should definitely fix this long-standing issue.
from osmdroid.
... and perhaps we should only call onLayout if the map orientation is != 0 || 180
from osmdroid.
onLayout is only about positionning visible child views. It does nothing else.
Effectively, in scrollTo, we could check map orientation != 0 before calling onLayout.
For != 180, I'm not 100% sure...
from osmdroid.
Let me know if that works for you!
from osmdroid.
It works!
from osmdroid.
Excellent! I will close this issue.
from osmdroid.
Related Issues (20)
- How to support GCJ-02 HOT 7
- Cannot navigate to a fragment after clicking on a marker HOT 1
- .
- Custom ZoomIn and ZoomOut buttons. How to implement custom zoomOut/zoomIn buttons? HOT 2
- Map animating to previous state after a couple of seconds with Jetpack Compose HOT 1
- java.lang.NullPointerException: Attempt to invoke interface method 'boolean org.osmdroid.views.overlay.OverlayManager.add(java.lang.Object)' on a null object reference HOT 2
- IP tracker and ad in wiki HOT 3
- open street map don't display
- TileSourceFactory US aviation maps don't load any more
- Writing and reading data from the real time database for Osmdroid HOT 1
- delete markers
- Animating the movement of a cursor along a polyline with two colors codes: the completed part and the part to do ? HOT 1
- displaying the route and deleting the marker zi database HOT 1
- BingMapTileSource always crash HOT 2
- Some issues when initializing mapsforge
- Zoom changes ignored if performed while an animation is underway
- Issue: GroundOverlay bad placement when invalidate map
- GroundOverlay - Draw White Image on Android 11
- Map View throwing Error as Too many receivers, total of 1000, registered HOT 1
- CPU usage continually between 30 and 40% when on a closed network HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from osmdroid.