Giter Site home page Giter Site logo

Comments (12)

kurtzmarc avatar kurtzmarc commented on July 24, 2024

You will experience integer overflow at those zoom levels. It will work okay in some locations, but eventually it will overflow and crash.

from osmdroid.

kjeremy avatar kjeremy commented on July 24, 2024

Hm. We haven't seen an issue with that but I believe you. Is there a
recommended route for adding this sort of capability?

On Tue, Jun 17, 2014 at 2:01 PM, kurtzmarc [email protected] wrote:

You will experience integer overflow at those zoom levels. It will work
okay in some locations, but eventually it will overflow and crash.


Reply to this email directly or view it on GitHub
#46 (comment).

from osmdroid.

devemux86 avatar devemux86 commented on July 24, 2024

What was the reason for not using doubles from the beginning?

from osmdroid.

kjeremy avatar kjeremy commented on July 24, 2024

I think it was because they were slow on original Android devices. That's why google uses ints everywhere for the map api (at least V1, haven't checked out V2).

from osmdroid.

devemux86 avatar devemux86 commented on July 24, 2024

Google seems to have moved to doubles at API v2.
https://developer.android.com/reference/com/google/android/gms/maps/model/LatLng.html

Also MapBox implementation (Osmdroid fork) has moved to doubles.
https://github.com/mapbox/mapbox-android-sdk/issues/61

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

I think the reason Google Maps used 1E6 is to have fixed precision when passing lat/longs around. They still (likely) have to convert to doubles to do Mercator calculations.

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

... and we probably have kept it around because we aim to mirror the Google Maps v1 API, even if it has been superseded by v2 that uses doubles. If we are going to break from that history, then I'd prefer doubles.

from osmdroid.

devemux86 avatar devemux86 commented on July 24, 2024

If we are going to break from that history, then I'd prefer doubles.

👍

from osmdroid.

kjeremy avatar kjeremy commented on July 24, 2024

doubles 👍

from osmdroid.

MKergall avatar MKergall commented on July 24, 2024

doubles 👍

from osmdroid.

neilboyd avatar neilboyd commented on July 24, 2024

I'd prefer to keep the consistency with v1. If we're going to go to v2 then do it completely.

from osmdroid.

kurtzmarc avatar kurtzmarc commented on July 24, 2024

I am going to close this question since it has been superseded by #48.

from osmdroid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.