Comments (17)
I'd just like to point out that the $1/mo plan now literally mentions Anki now, as a motivation to purchase the plan.
IMHO, that's tacit endorsement of DA. Maybe e-mail them and double-check? But it sounds to me like this needs to be re-enabled!
from anki-addons.
I just wanted to point out a rudimentary hack for anyone interested in this issue that enables access to the Forvo mp3 files by circumventing the official API entirely and no sign-up is required.
I modified the original ForvoDownloader
class from the forvo-feature branch to look like this (and saved it in a file forvo_free.py
in the downloaders
module:
...
import re
import base64
from ..download_entry import DownloadEntry
from .downloader import AudioDownloader
class ForvoDownloader(AudioDownloader):
"""Download pronunciations from Forvo via accessing the website instead of their API."""
def __init__(self):
AudioDownloader.__init__(self)
self.file_extension = u'.mp3'
self.icon_url = 'http://www.forvo.com/'
self.field_data = None
def download_files(self, field_data):
"""
Get pronunciations of a word from Forvo
"""
self.downloads_list = []
self.field_data = field_data
if field_data.split:
return
if not field_data.word:
return
self.maybe_get_icon()
assert (self.language)
webPageUrl = "https://forvo.com/word/%s/#%s" % (self.field_data.word, self.language)
webPageText = self.get_data_from_url(webPageUrl)
PageTextList = re.findall("<em id=\"%s.*?</article>" % self.language, webPageText, re.DOTALL)
if len(PageTextList) == 0:
return '{"status":"error"}'
PageText = PageTextList[0]
pronunciations = re.findall("Play\(\d+,'(.*?)'", PageText)
for l in range(len(pronunciations)):
pronunciations[l] = "https://forvo.com/mp3/" + base64.b64decode(pronunciations[l]).decode()
self.get_items(pronunciations)
def get_items(self, items_list):
for itm in items_list:
extras = dict(Source='Forvo.com')
if self.language:
extras['Language'] = self.language
try:
file_path = self.get_tempfile_from_url(itm)
# I guess the try is not really necessary. Anyway.
except (ValueError, KeyError):
continue
entry = DownloadEntry(
self.field_data, file_path, extras, self.site_icon)
entry.file_extension = self.file_extension
self.downloads_list.append(entry)
You also need to register this class in the __init__.py
of the downloaders module:
...
from .forvo_free import ForvoDownloader
downloaders = [
...
ForvoDownloader(),
]
from anki-addons.
Looks like Forvo changed their policies. There is now a buck/month plan. They still say not encourage customers to get keys”, but when they *pay for the key, that doesn’t make too much sense.
What is not making sense, too, is that they say “no caching” and “creative commons” both.
Worth watching. Maybe there will be a general Forvo downloader some day.
from anki-addons.
Is there still no interest on the forvo downloader? I am willing to pay the $1 month for the convenience and I am sure other users would be. Perhaps there could be a dialog where the user can input his or her API key and thus enable the forvo feature. If there is interest on this, I might be able to write it myself and submit a PR. Great job with the downloader!!! I use it almost everyday and it is an essential part of my Anki work-flow.
from anki-addons.
Short answer: no.
On the other hand, i think giving another developer a hand is something else than encouraging end users to get a Forvo key. So, just look around at the branches of this repo. Or more specific, at the downloaders directory.
from anki-addons.
Thank you.
from anki-addons.
I added the forvo downloader, and replaced the init.py file in my downloaders folder with the one here, as well as replacing the text XXXXXXXX with my forvo API key...but am having a lot of issues! Can anyone help me?
from anki-addons.
Looks like you copied a saved web page to __init__.py
. That won’t work. Even if the web page was showing an appropriate Python script.
And where is “here”? There is no link in your comment.
You should copy back the old __ini__.py
, get it from here (see? a link!) or re-download the whole add-on. In cases one and three you should then edit the file.
from anki-addons.
Ah OK, thanks I just copied and pasted the text into the file and it works great now.
from anki-addons.
The Forvo web page still says "You can't (…) encourage end users to get their own API keys. This is forbidden.”, so i will not encourage end users to get their own API keys.
from anki-addons.
Ah I see, that is such a bizarre policy... Yet they ask for donations on their main website, as if it were a non-profit project. Thank you for your reply!
from anki-addons.
No, their terms of use are largely unchanged, still contain
- It is not allowed to cache audio pronunciations.
- You can't […] encourage end users to get their own API keys.
from anki-addons.
As this is free software, other people can do that, and risk the legal trouble, if they want to.
I am not too motivated to work on this any more.
from anki-addons.
OK, nice.
At the moment i am not 100 % sure that i won’t use a variant of this idea.
Also:
- This is just a comment, not a git commit in your repo.
- The name
ForvoDownloader
is already taken for the API based version. - The code looks like Python 2, and so like an Anki 2.0 add-on, not an Anki 2.1 add-on.
from anki-addons.
Would you like me to create a pull request with points 1.-3. fixed? I wasn't sure if you were interested so I didn't invest the time yet.
Re: 3. I thought the plugin is Anki 2.0 only?
from anki-addons.
3: Yes. When i have come around to updating this add-on to 2.1, then i’ll have another look at this and i may – or may not – do Forvo this way.
from anki-addons.
3: Yes. When i have come around to updating this add-on to 2.1, then i’ll have another look at this and i may – or may not – do Forvo this way.
See also https://ospalh.github.io/anki-addons/2017/10/26/Anki_21.html
(The motivation that went up to “a bit” has gone down again, to “maybe a tiny bit some time”.)
from anki-addons.
Related Issues (20)
- Replay button plugin shows text instead of image HOT 3
- Japanese - Nothing Downloaded HOT 9
- "remap replay audio button to plus key" and "More shortcuts" HOT 1
- deck_name_in_title 2.1 HOT 4
- [feature request] replay button styling in add-on not in template HOT 7
- Addressing potential Cookie Monster incompatibilities with other add-ons
- Make the way the nid in "Add Note ID" is calculated optional HOT 2
- Recently not working for japanese, but worked perfectly a few days ago. HOT 3
- I get this error after installing the addon HOT 3
- Change the place of button HOT 1
- Cannot replay from the start sometimes if a field has many audio clips HOT 2
- Replay buttons on card and 2.1.20 HOT 9
- downloadaudio Error on Anki 2.1.20 Beta 5 HOT 2
- add_note_id: importing new cards into a note with Note ID field
- Add_Note ID no longer works in Anki 2.1.29+ HOT 4
- make note-id a real uuid HOT 4
- Changing note id to uuid breaks compatibility with linking HOT 1
- Replay buttons on card plugin not working for Anki 2.1.15 HOT 1
- Not support 2.1.49
- 插件启动失败
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from anki-addons.