Giter Site home page Giter Site logo

Comments (10)

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Arthur Hsieh (Bitbucket: arthur960304).


  • Edited issue description

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Arthur Hsieh (Bitbucket: arthur960304).


  • Edited issue description

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Arthur Hsieh (Bitbucket: arthur960304).


  • Edited issue description

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


Hi Arthur. Could you post the output of

$cat build.bash

I just want to verify that you have the latest version of the build script. Thanks!

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Arthur Hsieh (Bitbucket: arthur960304).


Here is the output:

#!python

#!/usr/bin/env bash

#
# Copyright (C) 2018 Open Source Robotics Foundation
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
#

# Builds a Docker image.

if [ $# -eq 0 ]
then
    echo "Usage: $0 directory-name"
    exit 1
fi

# Get path to current directory
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

if [ ! -d $DIR/$1 ]
then
  echo "image-name must be a directory in the same folder as this script"
  exit 2
fi

user_id=$(id -u)
image_name=$1
image_plus_tag=$image_name:$(date +%Y_%b_%d_%H%M)

docker build --rm -t $image_plus_tag --build-arg user_id=$user_id $DIR/$image_name
docker tag $image_plus_tag $image_name:latest

echo "Built $image_plus_tag and tagged as $image_name:latest"

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


Thanks! I think this is a localization issue resulting from the fact that you have Chinese characters in your date string. Could you try replacing the following line in the build.bash script:

image_plus_tag=$image_name:$(date +%Y_%b_%d_%H%M)

with

image_plus_tag=$image_name:$(date +%Y_%m_%d_%H%M)

and re-run?

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Arthur Hsieh (Bitbucket: arthur960304).


It works! Thank you so much!

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


Great! Glad it's working.

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Michael McCarrin (Bitbucket: m1chaelm).


Opening a new issue to address the root of the problem: https://osrf-migration.github.io/vrx-gh-pages/#!/osrf/vmrc/issues/47/buildbash-can-pass-illegal-input-to-docker (osrf/vmrc#47)

from vrx.

osrf-migration avatar osrf-migration commented on August 20, 2024

Original comment by Brian Bingham (Bitbucket: brian_bingham).


  • changed state from "new" to "resolved"

from vrx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.