BGP add path support

[natesales]

BGP add path support

[natesales]

Fantastic, works great now. Thanks for the quick fix!

[fujita]

Please use per-family config style like

[[neighbors]]
  [neighbors.config]
    peer-as = 65002
    neighbor-address = "10.0.0.2"
    [[neighbors.afi-safis]]
      [neighbors.afi-safis.config]
        afi-safi-name = "ipv4-unicast"
      [neighbors.afi-safis.add-paths.config]
        receive = true
        send-max = 8

[fujita]

The latest code explicitly returns an error for global add path config.

[natesales]

Thanks - that config works great on gobgp but not rustybgp. Here's my new full config, which works great and receives additional paths under gobgp, but the same config under rustybgp is stuck in Idle with the peer reporting "required capability missing".

global:
  config:
    as: 34553
    router-id: 192.168.90.4
    port: 179

  apply-policy:
    config:
      default-import-policy: accept-route
      default-export-policy: reject-route

neighbors:
  - config:
      peer-as: 34553
      neighbor-address: 192.168.90.1
    afi-safis:
      - config:
          afi-safi-name: ipv4-unicast
        add-paths:
          config:
            receive: true

[fujita]

Can you share the pcap file? I need open messages from both (one is rustybgp, and another is what?)

[natesales]

The remote side is BIRD 2.0.7; admittedly an older version of BIRD, but given GoBGP works correctly I suspect an issue on the rustybgp side. See attached pcap

rustybgp-bird.tar.gz

[fujita]

Thanks!
I fixed the bug. Can you try the latest master?