Giter Site home page Giter Site logo

Comments (8)

ota-meshi avatar ota-meshi commented on June 15, 2024 1

I think we need to replace jsdoctypeparser with jsdoc-type-pratt-parser. It seems that eslint-plugin-jsdoc was also replaced quite a while ago.
https://www.npmjs.com/package/jsdoc-type-pratt-parser

from eslint-plugin-regexp.

RunDevelopment avatar RunDevelopment commented on June 15, 2024 1

Are there any other rules that should be added to the recommended set?

Nope.

Are there any old ones to drop?

We have a few deprecated ones. We might as well remove them for good.

I noticed that no-super-linear-move is not included in the recommended config.
I would like to include this in the recommended config, what do you think?

Not a good idea, unfortunately. The issue is that most cases of super linear moves simply cannot be fixed. You would need to switch to a different regex engine... This isn't an option most of the time, so I did not include the rule in recommended.

from eslint-plugin-regexp.

RunDevelopment avatar RunDevelopment commented on June 15, 2024 1

Alright, I think we're good to go.

I thought of 2 things that we could do to improve the new rules, but it turned out that we already did both of them, so that's good :) Now my only worry is that people might have trouble upgrading to 2.0.0, because we increased our requirements by a lot (nodejs, ESLint, Intl.Segement and Firefox). But this is an issue that will solve itself with time, so we probably don't have to worry about it.

So I think we're ready.

from eslint-plugin-regexp.

ota-meshi avatar ota-meshi commented on June 15, 2024 1

I just released v2 🎉
https://github.com/ota-meshi/eslint-plugin-regexp/releases/tag/v2.0.0

from eslint-plugin-regexp.

ota-meshi avatar ota-meshi commented on June 15, 2024

@RunDevelopment
I noticed that no-super-linear-move is not included in the recommended config.
I would like to include this in the recommended config, what do you think?

from eslint-plugin-regexp.

RunDevelopment avatar RunDevelopment commented on June 15, 2024

I guess we're in a pretty good spot to release v2.

But I would let it sit for a week or two and only release 2.0.0 then. Maybe there's still something we'll find.

from eslint-plugin-regexp.

ota-meshi avatar ota-meshi commented on June 15, 2024

That's a good idea. I'll prerelease again and wait a week.

from eslint-plugin-regexp.

ota-meshi avatar ota-meshi commented on June 15, 2024

I will release v2. If your project requires support for older ESLint or Nodejs, I think we can add support for them later. If so, please let me know.

from eslint-plugin-regexp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.