Portability to Ubuntu

[otsaloma]

Portability to Ubuntu

[otsaloma]

Mpv on bionic does not support the --vf=scale=128:128/dar option syntax. I had to remove "/dar" from the option to make it work. As I could not locate any documentation about /dar I cannot provide a clean fix. I presume /dar refers to the display aspect ratio, and in fact thumbnails look compressed as a result. I could not find an equivalent setting for bionic's mpv (--vf=scale=128:-2 comes close but produces oversized icons for portrait mode videos).

I added that dar over two years ago to fix the aspect ratio in some cases, I think it was "anamorphic" videos where the container metadata contains the true display aspect ratio. So, your fix should be good if you need compatibility with a really old mpv.

d8b03d0

On Debian and Ubuntu, the Gnome install path is /usr/bin, so the install script and the .thumbnailer file need tweaking to remove '/local' from all paths. With the bubblewrap security, symlinks are not sufficient.

If you set the PREFIX in the install command, it should install under /usr if that's what you like.

make
make PREFIX=/usr install

[driehuis]

Thanks for your quick response!

Could you point me towards online documentation for the "/dar" option to the scale video filter? I could not find it anywhere...

Sorry for scribbling these "notes to self" in the issue tracker :-) I'll see if I can add build support for Debian and Ubuntu and submit a proper pull request. Rust is new to me, but adding a command line flag to tweak the mpv command line will be an interesting exercise.

[otsaloma]

I think mpv in some way uses ffmpeg's filters, so the documentation is there.

https://ffmpeg.org/ffmpeg-filters.html#Options-1

If you're thinking of some kind of a fix, I recommend just forking the code. Ubuntu 18.04 is already old, it's not the latest LTS, I don't want to include any work arounds for an old OS.