pre-commit

[michalk8]

pre-commit

[marcocuturi]

Hi Michal

black: for formatting (also would switch to 4 spaces instead of 2)

I think the 4 spaces makes life more difficult when sticking to the 80 characters / line rule. Since the entire codebase is written with 2 spaces, I think I'd rather stick to 2 :)

Example file I like using is here, though there are other checks, such as for typing and documentation: https://github.com/theislab/squidpy/blob/master/.pre-commit-config.yaml
black/isort are configured here: https://github.com/theislab/squidpy/blob/master/pyproject.toml#L5-L58

This sounds good! So we only need to add your .pre-commit-config.yaml to the repo, right? please go ahead with a PR, I am happy to validate it.

[giovp]

on a related note, I'd add this additional flags to .gitignore

# Distribution / packaging
.Python
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
pip-wheel-metadata/
share/python-wheels/
*.egg-info/
.installed.cfg
*.egg
MANIFEST

[marcocuturi]

That sounds like a good idea! I am not sure it is customary to add the .gitignore in the github folder, but it does indeed make life a bit easier for people that fork and want to send a PR for the first time. If you think it's usual I am happy to add it too if you send a PR!