Giter Site home page Giter Site logo

Comments (5)

marcocuturi avatar marcocuturi commented on June 14, 2024

So I guess there are two options:

  • do nothing, but at least it does fail (so it's not a silent error)
  • pass a warning message? I feel that if we do this we might have to do it for other parameter selections that may not be always necessarily valid.

from ott.

zoepiran avatar zoepiran commented on June 14, 2024

First of all, maybe an intermediate resolution is to add some docs, because from the manner it fails the user cant really understand this is the source. In addition, in an extreme situation it may be that the shapes are such that it won't fail.
And, maybe worth thinking which parameters we should check for to ensure valid GW ?

from ott.

marcocuturi avatar marcocuturi commented on June 14, 2024

another option could be to drop it explicitly (i.e. pop it from kwargs and replace by False)?

from ott.

zoepiran avatar zoepiran commented on June 14, 2024

yes. probably easiest.

from ott.

zoepiran avatar zoepiran commented on June 14, 2024

together with @michalk8 found the source of the original failure (misusage of jnp.where). @michalk8 wants to allow online for GW and will fix accordingly

from ott.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.