Comments (4)
kfkaplan
commented on July 20, 2024
It was originally intended to resample a single spectrum it is called onto the wavelength grid of a provided EchelleList object and called something like this:
ResampledList = SingleSpectrum.resample_list(ListToResampleTo)
The same functionality is provided by what is now in utilities.py which would be called like this
ResampledList = resample_list(SingleSpectrum, ListToResampleTo)
It could be moved from the EchelleList to Echelle class and called like so:
ResampledList = ListToResampleTo.resample_list(SingleSpectrum)
It probably is easiest to just remove the method from Echelle and leave it as a stand alone definition in utilities.py to avoid confusion.
from muler.
kfkaplan
commented on July 20, 2024
I will just remove it in my next pull request.
from muler.
kfkaplan
commented on July 20, 2024
Wow I totally forgot about this. I just removed resample_list from echelle.py in my latest pull request Updates to normalize() #81. The definition in utilities.py should be the one everyone uses.
from muler.
kfkaplan
commented on July 20, 2024
This has been resolved in pull request #81 which is now merged with Main. resample_list was moved to utilities.py as its own definition.
from muler.
Related Issues (20)
- Plot does not show up HOT 2
- Interoperability of rtell IGRINS files with revised uncertainty correction HOT 3
- Masking Spectra HOT 6
- Weirdness with .remove_outliers method HOT 9
- PCA Telluric Model
- Weird Plotting Glitch HOT 2
- IGRINS spectra missing metadata check warning displayed whenever a new IGRINSSpectrum object is created
- Feature Request: Absolute flux calibration of IGRINS spectra HOT 2
- Modularity Discussion: Which operations should reside in IGRINS plp, versus muler, versus third party? HOT 2
- Feature request: Validate spectra and error handling HOT 1
- User feedback: Units can be annoying HOT 2
- Tutorials were breaking because we were pip installing muler in the requirements.txt HOT 1
- Question about Plotting HOT 1
- Adopt more conventions and strategies from lightkurve
- IGRINS: Make a reusable function for classifying IGRINS input based on its filename
- Support an IGRINSSlit class HOT 2
- numpy updates - np.int deprecated HOT 2
- Standardize muler dependencies HOT 1
- Prune stale branches
- Promoting cross-talk with specutils: Have we invented anything that should move to specutils, aka "upstreaming". HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from muler.