Comments (25)
@hazcod by all means. I have initialized the issue area on my fork, and will try to address any small issues in the coming days/weeks but it is likely where I will get to a point where I am happy, create a final release, and then mark the repo as no longer maintained in the README.
from apaxy.
I just created two pull requests:
Take the one you want and discard the other one.
The first one only revert commit bb21c1a, while the second pull request revert commit bb24c1a and commit 8d8c15b. All this is explained in my previous comment in this thread.
from apaxy.
i was able to fix this by editing the /share/.htaccess
file to replace all instances of theme/
with /share/theme/
.
from apaxy.
I had the same issue where only my top folder (where I installed this tool) had the theme showing and fixed it by replacing all instances of theme/
with /theme/
in the .htaccess
file. For example:
AddIcon /theme/icons/archive.png .7z .bz2 .cab .gz .tar
Instead of the original
AddIcon theme/icons/archive.png .7z .bz2 .cab .gz .tar
That way the webserver always looked for a theme folder in the top level directory, rather than looking for a theme folder relative to the current directory.
from apaxy.
This regression is due to #55 (and particularly commit bb21c1a). I hope this change will be reverted as apaxy does no longer work the whole tree anymore.
The (hopefully temporary) workaround is to replace:
AddIcon theme/icons/archive.png .7z .bz2 .cab .gz .tar
by
AddIcon /{FOLDERNAME}/theme/icons/archive.png .7z .bz2 .cab .gz .tar
As mentionned by @programster, /{FOLDERNAME}
can be null if apaxy is installed at root. In this case, follow @programster advice:
AddIcon /theme/icons/archive.png .7z .bz2 .cab .gz .tar
In the other case, when apaxy is not installed at root, but into the myfolder
directory, use the following syntax
AddIcon /myfolder/theme/icons/archive.png .7z .bz2 .cab .gz .tar
And @AdamWhitcroft, can you please revert to bad commit?
from apaxy.
Maybe we should just use someones active fork, as he doesn't answer on anything
from apaxy.
I would give it up to a week. It looks like this is an old thread that has been "revived" by me less than 24 hours ago by adding a comment. It was stale since 11th May.
from apaxy.
@AdamWhitcroft is alive, he's twitting. Maybe someone can twit him.
The best solution would for @AdamWhitcroft to update apaxy, or the hear from him that he's not willing to maintain apaxy any more. It would hence be the time to a friendly fork. I'm not fond a aggressive fork if I can avoid it.
from apaxy.
As there is no release of apaxy and no alternate branch to refer to, I decided to stick with the last commit (66e30f0) before the bug was introduced.
I need to identify a specific version of apaxy as I'm working on an automated install of apaxy (using ansible).
It would be great to have releases, or at least another branch (which could be named develop
) in order to keep the master branch bugfree.
from apaxy.
I've forked this repo and fixed the issues in my version:
https://github.com/programster/Apaxy
I also changed the style so that max-width is set to 100% which I believe is much better, especially when you have long filenames.
from apaxy.
Great @programster ! Could you comment on all fixed issues with a link to your fork please? Thanks!
from apaxy.
@oupala, @hazcod, @programster It's not that I'm not willing gentlemen, it's simply a free-time issue. I'm working through as many of the issues today as I can. Sorry about that.
from apaxy.
I've created a develop
branch where I'll be reverting files that have weird commits in them. If one of you could just check them out to make sure you're happy, and then do a merge request I'll merge into master and then we can work on a release.
from apaxy.
Thanks @AdamWhitcroft for your answer, and for taking this time for apaxy.
I don't think that your develop
branch is ok for me. Let me explain you why.
- First, with the current version of the htaccess.txt file, the path is hard-linked to root path (
/theme/...
). It is hard to know what to change in order to change the root path where apaxy is installed. For the previous version of the htaccess.txt file, it was clear (and documented in the readme) to know what to change to follow the installed path of apaxy (/{FOLDERNAME}/theme/...
). - Second, the
wrapper
css class have been changed from 500px to 100%. 500px was too small, but 100% is too large, especially on large screens where it become very hard to follow lines and to know when a file has been modified or how big it is.
before
.wrapper {
max-width: 500px;
}
after
.wrapper {
max-width: 100%;
}
in my opinion, the best compromise would be 900px:
.wrapper {
max-width: 900px;
}
Is it all clear for you? I can make a pull request if you want to.
from apaxy.
@oupala Thanks for that. If you make a PR on develop
I'll go ahead and merge those in. I wasn't really happy removing the pathing stuff but it was requested a few times. I'd rather the instructions be clearer than faster.
from apaxy.
The pull request has been merged the the develop
branch has been tested by myself: it works like a charm!
It could be cool now to merge develop
to master
and possibly to add a tag on a commit to a specific version tag, and why not releasing a version...
By the way, why did you decide to rename Apaxy
to package-Apaxy
? It appears to be a strange decision to my mind...
from apaxy.
@oupala Good stuff! I'll go ahead and merge develop into master in the next couple of days (just super busy at the moment.)
The reason I renamed it is because I moved my project pages into their own GitHub repo's so my main website repo was less cluttered. Unfortunately, I couldn't keep this repo named Apaxy and use GitHub project pages with the same name as it was causing weird redirects. Appending with packgage-
was the best system I could come up with for renaming repos that have downloadable content.
Is there a better way I could do this?
from apaxy.
Great news @AdamWhitcroft I'll stick with the develop
branch until you merge.
I see what you wanted to do: separate your github pages from you real repo. But the right way to do that is to have a separate gh-pages
as you have in the original Apaxy repository.
But why do you want to do that? You're not using the gh-pages for Apaxy? And you now have to maintain twice more repository than before...
from apaxy.
@oupala I wasn't aware I could do that :/ So you're saying I could have 1 repo called apaxy
(it needs to be lowercase for the url), and have the main Apaxy package download in the master
branch, and use the gh-pages
branch for the static website files for http://adamwhitcroft.com/apaxy?
If so, mind blown.
Edit: I've read up on how to do it! Thanks so much for the suggestion, that definitely makes things so much easier!
from apaxy.
Explanations are here : https://pages.github.com/
Tell us if you change apaxy name back to apaxy
! :-)
from apaxy.
Hi, i find this again:
put .htaccess under /share (content is from https://github.com/programster/Apaxy/blob/master/apaxy/htaccess.txt)
put theme under /
But the style can not be applied
from apaxy.
Hi @daixiang0 !
Please open a new issue to discuss about your problem.
from apaxy.
Can this be closed? It looks like the original problem was resolved.
from apaxy.
The problem is resolved by commits merged into develop
. So master
branch is not (yet) fixed.
Once @AdamWhitcroft merge develop
into master
, then - yes - I do agree with you that this issue should be closed.
And I'm hardly waiting for this. We need master
branch to be bug-free as much as possible. This is what a master
branch is for.
from apaxy.
All tasks mentioned in this thread have been completed. It's time to close this issue.
from apaxy.
Related Issues (20)
- apaxy is missing a favicon HOT 3
- lightgallery is not working HOT 7
- Search in Header not working HOT 4
- Whic part of the dockerfile to i change to influence the root directory? HOT 4
- The error pages do not have valid HTML.
- Apaxy not working HOT 3
- htaccess HOT 1
- custom table structure HOT 3
- missing license for icons HOT 10
- Show current path HOT 6
- Not working with sub directories HOT 3
- combine Apaxy with htpasswd / Basic Auth HOT 5
- apaxy is switching to GPLv3 licence HOT 1
- Installscript should disable IndexOption "SuppressHTMLPreamble" HOT 7
- Demo or screenshots HOT 2
- Lightgallery Plugins HOT 4
- Minimise html/css/js HOT 4
- "Filtering Content" not working. HOT 1
- Add Pagination
- Can we have apaxy in the root folder itself?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apaxy.