Giter Site home page Giter Site logo

Comments (8)

dbyrns avatar dbyrns commented on August 18, 2024 1

I'm totally fine with new providers from tb14. We will make sure to not add trailing spaces though.

from magpie.

dbyrns avatar dbyrns commented on August 18, 2024

+1 for the script!
I think that we can safely remove it... @tomLandry ?

from magpie.

tomLandry avatar tomLandry commented on August 18, 2024

Remove what, the ogctb13 provider? If so, yes. But expect other "ogc_testbed" providers in the future.

from magpie.

fmigneault avatar fmigneault commented on August 18, 2024

ref #171

from magpie.

ChaamC avatar ChaamC commented on August 18, 2024

Other errors found :

  • sending an empty input
  • when editing an existing user, sending an info (username, email, ...) that is the same as the existing one ; in this case, it shouldn't produce an error, but accept the input anyway, without any change

from magpie.

fmigneault avatar fmigneault commented on August 18, 2024

@ChaamC
For the empty input, what is the error?
If it's a bad request, it is behaving as intended. The UI has very limited invalid operation error catching.
Could be added, but it becomes a bigger scope than current issue.

For the update, I believe that at least one change is expected on purpose in the UI, to ensure that an update is actually applied. The API will otherwise raise an error as a bad request (ie: asking something to be updated although nothing has to be updated).

from magpie.

ChaamC avatar ChaamC commented on August 18, 2024

@fmigneault
I thought we might want to avoid displaying an error on another page (a blank page with some error info). For example, I think when you create a service with the same name as an existing one, it just displays an error message in red on the same page just beside the text box, instead of loading a new error page.
But, we can choose to leave it as it is, since it is still catching the error!

from magpie.

fmigneault avatar fmigneault commented on August 18, 2024

@ChaamC
Yes, this is not critical to have it handled nicely in the UI for now. I think the returned error is conflict (409) which the expected behaviour. The blank page with error message is the way the API resolves the content-type (html) that is requested by the UI for the browser.

from magpie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.