VM IP static configuration

[joppino]

VM IP static configuration

[engelmi]

Hi @joppino, you are right - this feature is currently missing in the go-ovirt-client and we would need to add it here in order to enable this in the oVirt terraform provider.
The Initialization interface should be the right place to extend. I'll have a look at it.

[engelmi]

Hi @dyens, I created an issue for this (#250) - feel free to assign it to you. I have limited capacity, but I'll make sure to review your contribution and answer questions if some arise.

[dyens]

Hi!
@engelmi I would like to add all Initialization arguments to go-ovirt-client. I think, that all of them can be very useful.
I found, that you already work on NicConfiguration parameter cf304db.

After merge your feature, i would like to create PR for other params (and pr for terraform provider). What do you think ?

Also i think, that all of Initialization parameters are optional.
What do you think if save customScript and hostname in constructor for backward compatibility:

func NewInitialization(customScript, hostname string) BuildableInitialization {..} 

And all other parameters should be configured via builder:

initialization := NewInitialization("custom-script", "hostname").WithSomeParam("some-param");

[engelmi]

@joppino This has been implemented in #249. I'll create a new release soon. Closing this issue.

[dyens]

@engelmi TestVMCreationWithInit in live tests mode does not pass. This PR should fix: #251