LDMSD Bug When Using IPv6 address

[Snell1224]

LDMSD Bug When Using IPv6 address

[narategithub]

@Snell1224 Thank you for reporting this. There is indeed a bug in the IPv6 support in the case of no listening address given. In the mean time, you can work around the issue by specifying '::' as host name and it will listen to any address on both IPv4 and IPv6. For example:

# xprt option in CLI
$ ldmsd -x sock:411:::

or

# in config file
listen port=411 xprt=sock host=::

[tom95858]

@narategithub is this still an issue or can we close this?

[narategithub]

@tom95858 There is a bug in ldms_xprt_listen_by_name(x, host, ...). If host is NULL, the default listening address is '0.0.0.0'. I think I missed this when I added IPv6 support. Here's where the issue is:

ovis/ldms/src/core/ldms_xprt.c

Lines 4196 to 4207 in a2bdf82

	long ptmp;
	ptmp = atol(port_no);
	if (ptmp < 1 || ptmp > USHRT_MAX) {
	return EINVAL;
	}
	unsigned short port = ptmp;
	memset(&sin, 0, sizeof(sin));
	sin.sin_family = AF_INET;
	sin.sin_addr.s_addr = 0;
	sin.sin_port = htons(port);
	rc = ldms_xprt_listen(x, (struct sockaddr *)&sin, sizeof(sin),
	cb, cb_arg);

I'll post a patch today and will let you know.

[narategithub]

@Snell1224 the pull request that addressed this issue has just been merged. Could you please see if the issue is resolved?

[Snell1224]

@narategithub Yes, the issue has been resolved. Thank you for the information and fixing this!