Giter Site home page Giter Site logo

Comments (6)

ivnsch avatar ivnsch commented on May 17, 2024

Thanks for reporting. I'll check as soon as I have time... probably the coming weekend. In the meantime, feel free to investigate it, the library should be fairly simple to debug...

from chartlegends.

Boxleitner avatar Boxleitner commented on May 17, 2024

I get the same Problems with using the Legends within an UIScrollView. Is there a solution yet?

from chartlegends.

ivnsch avatar ivnsch commented on May 17, 2024

Evidently not, but as mentioned before feel free to give it a look, the library is quite small and should be understandable... the legends are a collection view so there shouldn't be anything particularly mysterious going on. otherwise I'll try to do this soon, sorry, very busy these days.

from chartlegends.

langhisc avatar langhisc commented on May 17, 2024

ChartLegendsView.swift, line 170:

fileprivate func register(cellType: CellType) {
        let frameworkBundleId = "com.schuetz.ChartLegends"
        if Bundle.main.path(forResource: cellType.reuseIdentifier, ofType: "nib") != nil {
            collectionView?.register(UINib(nibName: cellType.reuseIdentifier, bundle: nil), forCellWithReuseIdentifier: cellType.reuseIdentifier)
        } else if Bundle(identifier: frameworkBundleId)?.path(forResource: cellType.reuseIdentifier, ofType: "nib") != nil {
            collectionView?.register(UINib(nibName: cellType.reuseIdentifier, bundle: Bundle(identifier: frameworkBundleId)), forCellWithReuseIdentifier: cellType.reuseIdentifier)
        }
    }

These NIB files are not actually included in the ChartLegends bundle, so the if conditions always fail, and collectionView.register() is never called. This creates a crash with 100% frequency and renders the basic ChartLegends workflow unusable.
The missing NIB files are present in the example project's copy of the ChartLegends source. I tried manually copying them over to my project. Then, I got a different crash — something about a class not being compliant for a selector.

from chartlegends.

ivnsch avatar ivnsch commented on May 17, 2024

Well, I don't have time, but I'm quick at merging pull requests :)

from chartlegends.

ivnsch avatar ivnsch commented on May 17, 2024

Fixed in 0.0.5

from chartlegends.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.