Crashes after media scanning: IllegalArgumentException:

[fungs]

Crashes after media scanning: IllegalArgumentException:

[OxygenCobalt]

Have you tried disabling "Intelligent Sorting" in Settings -> Content? You should be able to do this before it crashes on a fresh install that's still taking awhile to load music @fungs. This would allow me to confirm what I think it is, that apparently the name comparison code that I do have really does require me to ensure that the comparison and equality results are 100% consistent.

[fungs]

@OxygenCobalt, I can confirm that the intelligent sorting (excluding articles etc.) option seems to cause this issue. I disabled it on a fresh install, not running into that issue and enabled it again, which caused the same error.

[OxygenCobalt]

Alright, this implies something I feared would happen. The issue is that intelligent name comparison plays a tad loose with the sorting contract. If you have a name like "FooBar" and "Foo Bar", the comparator will consider those equal, but the actual equality check won't. I thought this was okay after reading the comparator contract documentation, but apparently not. Thanks for reporting this @fungs.

[OxygenCobalt]

Might have figured out the issue in #810. More or less I was badly abusing Java comparators and violating their invariants, causing a crash with very specific data sequences. Care to try this out @fungs?

Auxio_Canary.zip

[fungs]

I will give it a try, probably this week!

[OxygenCobalt]

Update? @fungs

[fungs]

@OxygenCobalt I cleared the cache and data and verified, that the error still exists with the standard version. Then I installed the debug version and got exactly the same error, again. I can reproduce it by clearing cache and data of the app and giving permission to access media at first startup. It scans all media, the loads the media and then shows a message that it could not load the music. I have the option between "try again" and "more". When I select "more", I get the debug log in the first post. When I hit "try again", the music database is empty. When I then restart the app with the empty database, the loading is much faster and the music is there without getting any error.

Could it be that it just has problems parsing a (defective) music file?

I re-did the whole thing many times and also observed that in rare cases I don't get the error at all!

[OxygenCobalt]

Sorry for not responding @fungs. Have you tried 3.5.2? It turns out there were two points at which the sorting invariants were violated, 3.5.1 fixed one and 3.5.2 fixed the second.

[fungs]

I tried the version 3.5.0-debug you provided. Now I cannot reproduce it with the current 3.5.2. It may be fixed then. I can re-open this ticket, if it happens again.

Thanks!!!