Giter Site home page Giter Site logo

Potential memory leak about s3-proxy HOT 11 CLOSED

oxyno-zeta avatar oxyno-zeta commented on May 27, 2024
Potential memory leak

from s3-proxy.

Comments (11)

armin-malek avatar armin-malek commented on May 27, 2024 1

thanks, it has solved the problem!

PS: Out of this, do you use s3-proxy to make a tile map server ?
no it is just serving images from a private bucket for a machine learning project

from s3-proxy.

oxyno-zeta avatar oxyno-zeta commented on May 27, 2024

Hello @armin-malek ,

Thanks for your issue.

I never used this provider so I can't say if it is coming from this or not.
But I have other ideas in mind. Can you answer those questions please ?:

  • Do you have a lot of requests on your server ?
  • Do you have a lot of different path on your requests ? (/mybucket/file1, file2, file3, ...)

Regards,

from s3-proxy.

armin-malek avatar armin-malek commented on May 27, 2024

we have close to 8 million files in the bucket
and we serve around 7 objects per second (in reality it's a burst of 30 to 40 objects every few seconds),
the average object size is around 70KB

from s3-proxy.

oxyno-zeta avatar oxyno-zeta commented on May 27, 2024

I think I have an idea of why.

People requesting different files all the time ? Or are they the same for multiple minutes ?

from s3-proxy.

armin-malek avatar armin-malek commented on May 27, 2024

it's like an image hosting platform so yeah it should be mostly random objects

from s3-proxy.

oxyno-zeta avatar oxyno-zeta commented on May 27, 2024

Ok so I think I know why. This must come from prometheus metrics which are saving metrics per "request path". This can be patched for sure.

from s3-proxy.

armin-malek avatar armin-malek commented on May 27, 2024

Ok so I think I know why. This must come from prometheus metrics which are saving metrics per "request path". This can be patched for sure.

I'm not familiar with the code base but maybe an option to disable the metrics in the config file should do the trick
for now, i'll keep restarting the container every once in a while :)

from s3-proxy.

oxyno-zeta avatar oxyno-zeta commented on May 27, 2024

I've just released a new version. The 4.13.0 release have a configuration dedicated for this.

Here is an example:

# Metrics configuration
metrics:
  # Disable router path save in HTTP metrics
  disableRouterPath: true

That should fix your problem.

PS: Out of this, do you use s3-proxy to make a tile map server ?

from s3-proxy.

armin-malek avatar armin-malek commented on May 27, 2024

out of this too
currently it's logging every request to stdout, is there way to disable that too? i couldn't find it in the docs
if i'm not mistaken writing to stdout is not exactly cheap
what other log levels we have in the config file?

from s3-proxy.

oxyno-zeta avatar oxyno-zeta commented on May 27, 2024

Cool to hear this ! That's great!

Yes that's a feature to log everything. You can change the log level to error if you want only errors. All log levels from uber/zap logger are supported.

from s3-proxy.

github-actions avatar github-actions commented on May 27, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days

from s3-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.