Giter Site home page Giter Site logo

Comments (3)

holtjma avatar holtjma commented on September 28, 2024

Hello,

While this would reduce log clutter, it may also mask out legitimate errors in the underlying htslib crate/library that HiPhase is using. Currently, the errors from rust_htslib are passed through as warnings in this context, allowing users like yourself to identify issues with the input files that would be otherwise hidden without the warning. We could potentially add an option to disable the messages, but we would still leave these warnings on by default.

I wouldn't worry about run-time of the output, it is extremely insignificant relative to the rest of the phasing process.

Matt

p.s. glad HiPhase is working for you!

from hiphase.

davidyuyuan avatar davidyuyuan commented on September 28, 2024

Thanks, Matt. An option to turn it off would be great.

from hiphase.

holtjma avatar holtjma commented on September 28, 2024

In the hundred of samples we've run internally, we haven't found anything significant that those messages were capturing that were not caught elsewhere in the code. As a result, we elected to just downgrade them to DEBUG level.

This should be resolved in v1.4.1, thanks for the suggestion!

from hiphase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.