Comments (2)
most of the gltf files supply their paths relative to the gltf file.
the engine does not take this into account and tries to open the uri directly through stb.
file path correctness IS NOT CHECKED! so uninitialized int values are then used for mip calculations for example.
Given the timeline for the project, we could only do so much testing. We have improved the permutations of glTF files supported by the framework since the book release, but we limited our testing to the glTF samples provided by Khronos. If there are issues with other models, please share which model you are trying to load and we can look into it.
when the working directory is set to the same directory as the gltf file the gltf file cant be opened since file_directory_from_path cannot deal with paths not including at least one forward or backslash.
This is not a scenario we have considered. We'll take a look.
as a purchaser of the book i am very disappointment in the quality and robustness of these examples.
While I can understand the frustration, we clearly state in the book that this is not meant to be production quality code. As I mentioned, we had a limited time frame to complete the project and we focused on the algorithms implementation rather than making the code robust to all possible scenarios.
there are countless trivial issues i find just by reading through the code that shouldnt make it past any reasonable code review. neither on windows nor on linux the example works out of the box.
It makes following the book a lot harder and diminishes some of the value of the purchase.
While this might have been true at the time of release, we fixed some of the minor issues that were reported and most people seem happy with what we have delivered. As with any software project, there will be use cases we didn't think of. If you'd like to provide more details - or even better a PR - we'd be happy to look into it.
from mastering-graphics-programming-with-vulkan.
Closing due to inactivity. Feel free to re-open if needed.
from mastering-graphics-programming-with-vulkan.
Related Issues (20)
- debug_mesh pipeline validation error. HOT 2
- Zero size framebuffer if dynamic rendering not available. (Chapter 7) HOT 2
- Transfer capability is implied for graphics and compute queues HOT 1
- Issues with RX6600 HOT 17
- usability issue: the camera rotated when drag the imgui's window in demo chapter1 HOT 2
- a little confused HOT 3
- Mac version HOT 1
- Exits directly HOT 5
- No rule to make target 'chapter1' HOT 3
- Shader compilation on linux is broken HOT 2
- Compilation of IMGUI shader, and IMGUI render pass not working on Linux HOT 14
- replace "SDL2::SDL2" with "${SDL2_LIBRARIES}" in all 15 CMakeLists.txt files HOT 4
- So much differences in code between chapter 1 and 2, undocumented HOT 2
- why can't I compile in my macOS? with Arm M3 HOT 2
- Question about frustum aligned 3D texture HOT 3
- Issue with renderdoc capture from Chapter 11 HOT 2
- Can't run chapters 8,9,10,11,13,14 on Windows with the same error. HOT 3
- Transfer Synchronization HOT 4
- projected_p does not get negated. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mastering-graphics-programming-with-vulkan.