Giter Site home page Giter Site logo

Comments (8)

bethesque avatar bethesque commented on September 13, 2024 1

Done. pact-foundation/pact-mock_service@6ae7768

[Hides head in shame]

from pact-ruby.

uglyog avatar uglyog commented on September 13, 2024

Is this still an issue? I want to close off the corresponding issue in the specification project.

from pact-ruby.

sergei-matheson avatar sergei-matheson commented on September 13, 2024

Yeah, it is. I'll put a fix in for it this week. For now, I'll set both provider_state, and providerState, and check for providerState first on the provider side. That way it should handle the transition gracefully.

from pact-ruby.

bethesque avatar bethesque commented on September 13, 2024

It already does when reading

 @provider_state = attributes[:provider_state] || attributes[:providerState]

https://github.com/bethesque/pact-support/blob/master/lib/pact/consumer_contract/interaction.rb#L18

from pact-ruby.

mefellows avatar mefellows commented on September 13, 2024

FYI we now have two downstream issues logged at pact-foundation/pact-go#16 and pact-foundation/pact-js#34 (they both use this under the hood to generate contracts)

from pact-ruby.

bethesque avatar bethesque commented on September 13, 2024

Yeah, go needs to use providerState. The underscored one is way way outdated. Is there some code somewhere that is being copied that is propagating this misunderstanding? All the pact specs should be using providerState.

from pact-ruby.

mefellows avatar mefellows commented on September 13, 2024

I can update JS/Go to send provider state in (via the HTTP interface) as providerState, the probably I'm seeing is that when we use the Mock Service (which I think uses this Gem to do it), it generates a pact file with provider_state - is this the right place to track the issue?

from pact-ruby.

bethesque avatar bethesque commented on September 13, 2024

It's actually in the mock service code, but we already have enough issues, let's leave this here!

from pact-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.