Giter Site home page Giter Site logo

Comments (10)

unicornshell avatar unicornshell commented on June 19, 2024

ppdiffusers里attention.py里GEGLU模块缺少
def gelu(self, gate): if gate.device.type != "mps": return F.gelu(gate),但这并不在代码差异中,需要更改吗

from paddlemix.

unicornshell avatar unicornshell commented on June 19, 2024

似乎缺少models/attention.py的单测

from paddlemix.

LokeZhou avatar LokeZhou commented on June 19, 2024

ppdiffusers里attention.py里GEGLU模块缺少 def gelu(self, gate): if gate.device.type != "mps": return F.gelu(gate),但这并不在代码差异中,需要更改吗

不需要

from paddlemix.

LokeZhou avatar LokeZhou commented on June 19, 2024

似乎缺少models/attention.py的单测

如果torch 的diffusers里有这个单测则添加上去,如果没有就不需要添加

from paddlemix.

unicornshell avatar unicornshell commented on June 19, 2024

diffusers的attention_processor.py里存在的pytorch2.0版本的类需要在ppdiffusers里实现吗 像:
AttnAddedKVProcessor2_0,AttnProcessor2_0,LoRAAttnProcessor2_0

from paddlemix.

unicornshell avatar unicornshell commented on June 19, 2024

缺少2_0的类会导致新增的

ADDED_KV_ATTENTION_PROCESSORS = (
    AttnAddedKVProcessor,
    SlicedAttnAddedKVProcessor,
    AttnAddedKVProcessor2_0,
    XFormersAttnAddedKVProcessor,
    LoRAAttnAddedKVProcessor,
)

CROSS_ATTENTION_PROCESSORS = (
    AttnProcessor,
    AttnProcessor2_0,
    XFormersAttnProcessor,
    SlicedAttnProcessor,
    LoRAAttnProcessor,
    LoRAAttnProcessor2_0,
    LoRAXFormersAttnProcessor,
)

AttentionProcessor = Union[
    AttnProcessor,
    AttnProcessor2_0,
    XFormersAttnProcessor,
    SlicedAttnProcessor,
    AttnAddedKVProcessor,
    SlicedAttnAddedKVProcessor,
    AttnAddedKVProcessor2_0,
    XFormersAttnAddedKVProcessor,
    CustomDiffusionAttnProcessor,
    CustomDiffusionXFormersAttnProcessor,
    # depraceted
    LoRAAttnProcessor,
    LoRAAttnProcessor2_0,
    LoRAXFormersAttnProcessor,
    LoRAAttnAddedKVProcessor,
]

部分出现类似于"AttnProcessor2_0" is not defined的warning

from paddlemix.

shiyutang avatar shiyutang commented on June 19, 2024

@LokeZhou 请问这个PR #322 是否很快就能合入。

from paddlemix.

LokeZhou avatar LokeZhou commented on June 19, 2024

@LokeZhou 请问这个PR #322 是否很快就能合入。

ci通过后合入

from paddlemix.

LokeZhou avatar LokeZhou commented on June 19, 2024

diffusers的attention_processor.py里存在的pytorch2.0版本的类需要在ppdiffusers里实现吗 像: AttnAddedKVProcessor2_0,AttnProcessor2_0,LoRAAttnProcessor2_0

如果功能一致不需要;如果是因为2.0版本导致新增功能,则需要。

from paddlemix.

shiyutang avatar shiyutang commented on June 19, 2024

任务已完成 by @co63oc ,close issue。

from paddlemix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.