install failing on Windows 8

[paixaop]

install failing on Windows 8

[BenReilly]

I had some time so I did some repairing on my Visual Studio and now getting a different error

C:\Users\eric.ehlers\AppData\Roaming\nvm\v6.7.0\node_modules\npm\node_modules\node-gyp\src\win_delay_load_hook.c(34): error C2373: '__pfnDliNotifyHook2': redefinition; different t
ype modifiers [C:\_dev\carwars-gl\node_modules\sodium\build\sodium.vcxproj]
  C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\delayimp.h(134): note: see declaration of '__pfnDliNotifyHook2'
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Users\eric.ehlers\AppData\Roaming\nvm\v6.7.0\node_modules\npm\node_modules\node-gyp\lib\build.js:276:23)
gyp ERR! stack     at emitTwo (events.js:106:13)
gyp ERR! stack     at ChildProcess.emit (events.js:191:7)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\eric.ehlers\\AppData\\Roaming\\nvm\\v6.7.0\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuil
d"
gyp ERR! cwd C:\_dev\carwars-gl\node_modules\sodium
gyp ERR! node -v v6.7.0
gyp ERR! node-gyp -v v3.3.1
gyp ERR! not ok
C:\_dev\carwars-gl\node_modules\sodium\install.js:288
            throw new Error(cmdLine + ' exited with code ' + code);
            ^

Error: node-gyp rebuild exited with code 1
    at ChildProcess.<anonymous> (C:\_dev\carwars-gl\node_modules\sodium\install.js:288:19)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
npm WARN [email protected] No repository field.
npm ERR! Windows_NT 6.3.9600
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--save" "sodium"
npm ERR! node v6.7.0
npm ERR! npm  v3.10.3
npm ERR! code ELIFECYCLE

npm ERR! [email protected] install: `node install.js --install`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] install script 'node install.js --install'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the sodium package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node install.js --install
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs sodium
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls sodium
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\_dev\carwars-gl\npm-debug.log

[richchurcher]

I notice this thread nodejs/node-gyp#972 containing the same error, which recommends npm version of at least 3.10.8. You may wish to try:

npm i npm -g

followed by removing node_modules and running the install again.

[paixaop]

Did you run

npm config set msvs_version 2015

[BenReilly]

i did do npm config set msvs_version 2015
trying npm upgrade

edit: looks like the npm upgrade works. Might need to put that in the install instructions

[richchurcher]

Great! I'll throw up a PR for the instructions. I guess we can assume a minimum requirement of 3.10.8... I just 'stole' someone's Windows laptop to try to reproduce the issue.

[richchurcher]

Unfortunately I just tried to reproduce it on a Windows VM with Node 6.5, npm 3.10.3, and node-gyp 3.4.0 and it all went swimmingly. I guess we could add a generic, "if you run into trouble try upgrading npm" suggestion.