Comments (3)
Correction it's a custom preinstall
script we need to make... And we should assume node-gyp
is in PATH
..
Or we have to do it in the .gyp
file... and basically replace the libsodium build process.
http://n8.io/converting-a-c-library-to-gyp/
Apparently install script is an anti-pattern :)
https://docs.npmjs.com/misc/scripts#note-install-scripts-are-an-antipattern
from node-sodium.
Indeed the gyp file compiles lib sodium without using the library's original build system.
The issue that we've run into in the past is that by not running configure on libsodium the platform/architecture specific defines are not created which will cause incompatibilities and compilation errors.
We could create different conditional sections in the GYP for the supported platforms but then we would need to add and maintain each platform's section. This is not very maintainable.
Maybe the mid ground is to have a section for windows which would be the only system where automake tools are not easily available.
On Feb 25, 2015, at 19:44, Jonas Finnemann Jensen [email protected] wrote:
Correction it's a custom preinstall script we need to make... And we should assume node-gyp is in PATH..
Or we have to do it in the .gyp file... and basically replace the libsodium build process.
http://n8.io/converting-a-c-library-to-gyp/Apparently install script is an anti-pattern :)
https://docs.npmjs.com/misc/scripts#note-install-scripts-are-an-antipattern—
Reply to this email directly or view it on GitHub.
from node-sodium.
hmm... maintain a gyp section for windows would probably be the solution. Better than shipping binaries :)
Closing this issue, as a single gyp section is better for windows, than binaries... Also easier to maintain, binaries are the worst :)
Side note, I tested the develop branch locally and on heroku yesterday and it works both places. Granted We still need the ./configure hooked up to npm install, before the develop
branch is usable. But that should be a simple matter...
from node-sodium.
Related Issues (20)
- Angular/typescript usage HOT 6
- Fails to compile on openSUSE LEAP 15 (../deps/build/lib/libsodium.a: No such file or directory ) HOT 8
- Cant install sodium on my Pi HOT 2
- Compiling sodium on TravisCI fails HOT 1
- Console error 'msvsversiion not defined' when invalid Visual Studio Version is found
- Invalid ELF Header HOT 1
- Error installing on Windows
- make libsodium exited with code 2, pwhash_argon2i fails HOT 3
- NPM install fails with node-gyp error: cannot use a string pattern on a bytes-like object
- package install errors HOT 3
- How to pre-build Node Sodium?
- install.js support vs2019 please HOT 1
- Installing on Windows Failed HOT 1
- Way to use exists keypair which generated in Java HOT 1
- libbtool/libsodium not installing on Petrodctyle panel
- ed25519 decode / decompress HOT 1
- Cannot install with yarn berry
- Can't install sodium, please help me (Windows) HOT 1
- Does not compile on Linux ARM. HOT 6
- Is this library still maintained?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-sodium.