npm package is broken

[paixaop]

npm package is broken

[paixaop]

Will push a new version today
On 3/15/14, 7:29 AM, tearmann wrote:

The version in npm seems to be broken.

$npm install sodium
$grep -r"./tobuffer"

returns

|node_modules/sodium/lib/sign.js:var toBuffer = require('../lib/tobuffer');
node_modules/sodium/lib/box.js:var toBuffer = require('./tobuffer');
node_modules/sodium/lib/box2.js:var toBuffer = require('./tobuffer');
node_modules/sodium/lib/secretbox.js:var toBuffer = require('./tobuffer');
node_modules/sodium/test/test_toBuffer.js:var toBuffer = require('../lib/tobuffer');
node_modules/sodium/test/test_toBuffer.js: toBuffer = require('../lib-cov/tobuffer');
|

But the file being referenced from these locations is
|lib/toBuffer.js| with a capital B

The code in this repo seems to be correct so can we have another push?

Found as part of this telehash/telehash-js#10
telehash/telehash-js#10

—
Reply to this email directly or view it on GitHub
#9.

Thanks I thought this was abandoned so I started on a fork here
https://github.com/tearmann/node-sodium
That repo has the following updates:

1. Submodule approach abandoned and now takes the leveldb library approach using deps
2. Build moved over to node-gyp
3. Docker Node Test integration https://github.com/rvagg/dnt
4. Start of the move to tap test framework
5. Travis integration and initial pass

If you would consider putting this code and this repository under the Open Open Source Licence
https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md
I would love to submit a pull request and continue to work with you directly on this library.

Still to do

1. Integrate with a V8 abstraction layer maybe https://github.com/rvagg/nan
2. Improve gyp support for windows mac and smartOS
3. Complete the test suite and resolve some of the current failing tests.

Hope you like the direction suggested and whatever your decision thanks for starting such an awesome library :)

[paixaop]

Perfect. lets merge your changes in

[paixaop]

npm package updated should work now. Did a fresh install on my mac and all tests passed.
Version updated to 1.0.10

[paixaop]

After the merge I am getting errors on Mac

dyld: Symbol not found: _crypto_scalarmult_curve25519_base
    Referenced from: /Users/xxxx/work/node-sodium/build/Release/sodium.node
    Expected in: dynamic lookup

What needs to change in te gyp files to fix this? This is urgent as now the code will not work on Mac OS

Will take a look at that.
Seems like the symbol has changed maybe because we are linked now?

[paixaop]

Why are you converting the tests to tap?
If Tap is absolute need we can run the mocha tests with the tap reporter and we get the same output

Thanks for validating the mac build.
So the current npm package 1.0.10 still uses the old build script.
What pieces do you feel we waiting for before we move to the node-gyp version?

So https://github.com/paixaop/node-sodium/blob/master/package.json#L12 seems to be a problem as npm is only reporting 0.2.0 https://www.npmjs.org/package/mocha-istanbul

BTW do you hangout on IRC? #stackvm on freenode
Or [email protected] on jabber [email protected] too

Closing this because it's not true anymore :) For Linux and Mac
Windows coming soon.
TY @paixaop

[abenmrad]

Hi. I've made a fork of this project a few months ago. I came back here to see if there is anything new on this repo (I wasn't watching it).

Back when I forked this lib, libsodium was integrated as a submodule. I wanted to know why you abandoned that approach?

[paixaop]

Simpler and more robust build process.
But once the build/install development stabilizes I will revert to the
sub module so keeping up with libsodium will be easier

Best regards,
Pedro

On 5/15/14, 6:04 AM, The Syrian Watermelon wrote:

Hi. I've made a fork https://github.com/Mowje/node-sodium.git of
this project a few months ago. I came back here to see if there is
anything new on this repo (I wasn't watching it).

Back when I forked this lib, libsodium was integrated as a submodule.
I wanted to know why you abandoned that approach?

—
Reply to this email directly or view it on GitHub
#9 (comment).