Giter Site home page Giter Site logo

Comments (1)

fabian-braun avatar fabian-braun commented on August 22, 2024

Hello,
I'm a new user of this (nice!) library and the naming has caused a little confusion for me.
As a new user I expect the terms "service" and "container" are used according to how they're defined by docker-compose.
That is, a service is a "blueprint" to get a concrete container up and running.

When I first did docker.containers().container(name) to get a hold of my container I was unsure on what I had to pass as an argument. Consider the following compose-file:

version: '3'
services:
   service1:
      image: some/image
      command: "echo echo"
      container_name: "container1"

Should I pass container1 or service1 as name?
I think the api should clearly state that the service name must be passed. Either the parameter name should be changed to serviceName or the javadoc should state it.

from docker-compose-rule.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.