Comments (7)
It caused issues with running tests in parallel.
from docker-compose-rule.
Yes, imo the default should be randomised project names or you get all
kinds of problems with parallel tests.
docker-compose down
removes networks. We should be calling that after
running each test. Is this only something that affects people who choose to
not destroy the composition (and so not call down) afterwards? If so, maybe
we should warn them to give a fixed project name and about the networks
problem.
On Thu, 1 Sep 2016, 12:35 joelea, [email protected] wrote:
It caused issues with running tests in parallel.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#99 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYR48BUTLOr3GNTZxEnx5xsJMP_aEVTks5qlriNgaJpZM4Jyjek
.
from docker-compose-rule.
I just read #40. Are we still using ExternalResource
? That has some weird semantics iirc, like not calling after
if there was an exception, which could be exacerbating the problem.
from docker-compose-rule.
I think the ExternalResource
private Statement statement(final Statement base) {
return new Statement() {
@Override
public void evaluate() throws Throwable {
before();
try {
base.evaluate();
} finally {
after();
}
}
};
}
is safe for that, no?
from docker-compose-rule.
ah wait - the failure is if the error is in your before method; before should be in the try block. That's what could exacerbate the problem.
from docker-compose-rule.
@joelea can you elaborate on the "issues with running tests in parallel" you mention... do you mean running multiple instances of the same class at the same time? Or just multiple test classes that happen to be in the same folder?
from docker-compose-rule.
E.g. If you have two projects that both use the same docker compose file in different contexts, you can't run ./gradlew test --parallel. You can't e.g have a dev stack running and run the tests on a different cluster.
The bug here btw is that DCR can terminate having made no attempt to clean up its state. If DCR creates a network, it should delete it too, whether or not before() throws.
On Sep 30, 2016, at 20:58, iamdanfox <[email protected]mailto:[email protected]> wrote:
@joeleahttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_joelea&d=DQMGaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=mzXajGbPp7kc5a_CRzXttisFRf8mEsV3gcMrXd3MRoc&m=6p6JDu3oI16wHgpBHvaNj51NY70WogomHlUG1KYAy8w&s=E6OQAKKrmd8TBW7uwGiANF_0mStlG0xAdQq4Omr-X-4&e= can you elaborate on the "issues with running tests in parallel" you mention... do you mean running multiple instances of the same class at the same time? Or just multiple test classes that happen to be in the same folder?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_docker-2Dcompose-2Drule_issues_99-23issuecomment-2D250837960&d=DQMGaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=mzXajGbPp7kc5a_CRzXttisFRf8mEsV3gcMrXd3MRoc&m=6p6JDu3oI16wHgpBHvaNj51NY70WogomHlUG1KYAy8w&s=g85uuIvOgT7XEWfBPNm2Dv_Wj0cnp4nBlDUpwgkX75o&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AACmJW0WZZqOgzlVsgg9OplmkpNSnUZ8ks5qvWnUgaJpZM4Jyjek&d=DQMGaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=mzXajGbPp7kc5a_CRzXttisFRf8mEsV3gcMrXd3MRoc&m=6p6JDu3oI16wHgpBHvaNj51NY70WogomHlUG1KYAy8w&s=wI31cg1BQtV4IgtyPtPMXBGSCeh0NiUnKUNPe-vqW34&e=.
from docker-compose-rule.
Related Issues (20)
- Docker compose cluster shuts down after nested test class JUnit5 HOT 1
- `DockerCompose.exec()` that supports stdin
- Port matching is breaks when docker-compose ps output changes HOT 6
- commands fail on my computer HOT 4
- rule hangs if docker-compose wants input HOT 1
- Sync jars with Maven Central HOT 10
- Collecting logs behavior changes between version 0.34.0 vs latest HOT 2
- Containers still running after test finished (in success or failure)
- What is the correct dependency in order to use DockerComposeExtension (Junit 5) HOT 1
- Is there any trick to use docker-compose-rule to test kafka when producer is assync
- DockerComposeRule with large images gets killed by circle
- Late versions of java (e.g. Java 16) fail due to StreamEx
- Bintray has been deprecated HOT 1
- Broken for docker-compose v2
- Port matching breaks when consecutive ports are exposed
- Which repository now that bintray has shut down?
- Proposal for new ShutdownStrategy with a JVM ShutdownHook
- Ignore stderr returned from docker-compose command
- Upgrade baseline to 5.5.0 for IntelliJ Save Actions fix
- Usage of docker-compose-rule with Podman and docker-compose
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-compose-rule.