ADD build/distributions/*.tar (retain folder structure using files or include from project.buildDir?)

[palantir]

ADD build/distributions/*.tar (retain folder structure using files or include from project.buildDir?)

[uschi2000]

Johannes, try `dependsOn distTar`; this should move all output artifacts of the distTar task into the Docker build context.

…

On Fri, Dec 9, 2016 at 3:23 PM jsundqvist ***@***.***> wrote: Hi, I really like the approach of this plugin but have encountered a problem which prohibits me form using it: I have an artifact that is created by task:distTar and is located in build/distributions. From viewing the source code I can see that when no files argument is provided, the plugin will include all files *except* the ones in the build directory. This becomes problematic because my artifact is actually located in the build folder. And when I try to *explicitly* include my artifact, the path is not retained and the file is instead placed in the root of the build/docker sub-directory. This means that I would either have to relocate my artifact manually before running this plugin, or change my Dockerfile to look for the file in the root instead of in the build folder, neither of which I want to do. I have two suggestions to solve this problem: 1. optionally keep the folder structure when explicitly including files using the files argument. (preferred) 2. optionally include files from build (good enough) (I also tried to explicitly include "everything" but that seems to fail due to a stack overflow when creating the path, probably a bug. Steps to reproduce: files "${projectDir}" or files '.'). Thanks a lot! /Johannes — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#86>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGOdwWVKPhO9W17oISxNl0lUA6Lq9f1Oks5rGeLMgaJpZM4LJdYg> .

[jsundqvist]

Hey, thanks for the quick reply. I realize I probably should have included the docker snippet form my build.gradle. Sorry about that:

docker {
	name 'myorg/myapp'
	dependsOn tasks.distTar
	files 'build/distributions/'
}

I also tried with just dependsOn distTar as you said and the result is still a docker directory with everything but the build folder.

/Johannes

[uschi2000]

Mentioning "files" explicitly overrides the files included via dependsOn. Try just dependsOn, please.

…

On Fri, Dec 9, 2016 at 4:35 PM jsundqvist ***@***.***> wrote: Hey, thanks for the quick reply. I realize I probably should have included the docker snippet form my build.gradle. Sorry about that: docker { name 'myorg/myapp' dependsOn tasks.distTar files 'build/distributions/' } I also tried with just dependsOn distTar as you said and the result is still a docker directory with everything but the build folder. /Johannes — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#86 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGOdwZ34RCZI70SL_xy4pT9VQP7VIS7cks5rGfPagaJpZM4LJdYg> .

[jsundqvist]

Well, I was hoping you could tell from my first post that this is what I tried first. Sorry for being unclear.

I have had dependsOn tasks.distTar declared the whole time.
The following tasks are invoked when I run gradle with ./gradlew clean docker:

:clean
:compileJava
:processResources UP-TO-DATE
:classes
:jar
:startScripts
:distTar
:dockerClean UP-TO-DATE
:dockerPrepare
:docker

I now set the docker snippet to the following as per your request, and still get the same result:

docker {
	name 'myorg/myapp'
	dependsOn distTar
}

So, to repeat: When I run the above command without explicitly setting the files argument, I end up with everything except build in the docker subdirectory. Without looking into the code in-depth, this is confirmed to me from viewing https://github.com/palantir/gradle-docker/blob/develop/src/main/groovy/com/palantir/gradle/docker/PalantirDockerPlugin.groovy#L94. I guess the reasoning behind this logic would be to not introduce a recursive infinite loop. My suggestion in this case is to exclude "${project.buildDir.name}/docker" instead of "${project.buildDir.name}".

In either case, it's not working.

My gradlew version is 3.2, the version of your plugin is 0.9.2, I'm running Oracle Java 8 on Debian 8.

[uschi2000]

I tried the same setup and can't reproduce; can you link me to a repository, @jsundqvist ?

[uschi2000]

see #91

[jsundqvist]

Not sure hos this is related since you are not ADDing from buildDir in your Dockerfile. Aren't you effectively circumventing the bug by placing foo.tgz in the root of the project?

[uschi2000]

foo.tgz gets produced inside build/ and then copied into the docker context by the plugin.

[jsundqvist]

https://circleci.com/gh/jsundqvist/palantir-gradle-docker-issue-86/4
https://github.com/jsundqvist/palantir-gradle-docker-issue-86