Comments (5)
Thanks, I don't think those additional rule will impact things. If you're able to run snapshot versions, please try out the palantirtechnologies/policy-bot:snapshot
image to see if it fixes this behavior.
from policy-bot.
Gave the snapshot a quick test and looks good
Opened draft PR, required checks passed - correctly doesn't request reviews ✅
Moved PR out of draft - correctly requested reviews ✅
Thanks again!
from policy-bot.
Thanks for the report. This sounds like a bug and I think I found a probable cause, but just to confirm: is the snippet you shared the only rule in your policy that requests reviews or are there other rules involved too?
from policy-bot.
@bluekeyes Good question - it's the latter. Apologies, I should have posted the full config:
policy:
approval:
- or:
- Team approval
- Approval
disapproval:
requires:
teams:
- yyy
options:
methods:
disapprove:
comments: []
github_review: true
revoke:
comments: []
github_review: true
approval_rules:
- name: Team approval
requires:
count: 2
teams:
- yyy
options:
allow_author: false
allow_non_author_contributor: true
invalidate_on_push: false
ignore_edited_comments: true
ignore_update_merges: true
request_review:
enabled: true
mode: teams
methods:
comments: []
github_review: true
- name: Approval
if:
has_successful_status:
- "checks"
requires:
count: 2
teams:
- xxx
options:
allow_author: false
allow_non_author_contributor: true
invalidate_on_push: false
ignore_edited_comments: true
ignore_update_merges: true
request_review:
enabled: true
mode: random-users
count: 3
methods:
comments: []
github_review: true
Just in case it's relevant, all members of xxx
are in yyy
.
from policy-bot.
Thank you so much. I'll see if I'm able to try it today
from policy-bot.
Related Issues (20)
- `common.IsActor()` does not actually use `ctx` and can be simplified.
- Condition for not having specific label(s) HOT 6
- Status check clarification HOT 2
- Feature Request: Predicate to skip rule if a file was changed HOT 6
- Feature Request: Option to count skipped jobs in has_successful_status HOT 5
- Clarify why users are "disqualified" when approval is ignored
- Create new production Release 🚀 HOT 1
- Connecting lines broken when hiding skipped rules with errors
- requires.conditions not working correctly in rule HOT 2
- behavior when using `invalidate_on_push` and `ignore_commits_by`? HOT 2
- Rebase invalidates approval HOT 1
- Concurrent deployments can overwrite statuses unintentionally HOT 1
- Status checks not re-run when used with merge queue HOT 2
- Paths in public_url are removed from OAuth routes
- Re-evaluate policy when PR base branch changes
- has_successful_status may use incorrect check-run HOT 2
- can I have approval rule with has_author_in but in not form HOT 1
- /api/health endpoint does not actually indicate service health HOT 1
- How we can exclude bot from approval HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from policy-bot.