Giter Site home page Giter Site logo

Comments (4)

DonJayamanne avatar DonJayamanne commented on May 28, 2024 1

It seems the linters, intellisense providers, etc all run in a synchronous and single threaded manner. I feel that this could prove to be quite slow with larger code bases (with linters, code definition, hover, etc all happening in very quick succession). Wouldn't it be better to run the linters in a separate thread or process, with callbacks?

from python-language-server.

gatesn avatar gatesn commented on May 28, 2024 1

I agree multi-threaded would be preferable, happy to look at PRs! Right now almost all the providers act only on a single file so performance issues from large repos tend to be limited to only a few cases (where jedi looks at the entire python path for symbols e.g. code completion / go to definition etc).

We can open an issue for multi-threading but until it's clear performance is an issue I likely won't have time to make the change.

from python-language-server.

gatesn avatar gatesn commented on May 28, 2024

So currently the linters/formatters and any other providers are declared at the top of the PythonLanguageServer class.

The idea behind this (although not implemented at the moment) is that the initializationOptions can be used to choose between different providers. Notice we already use multiple linters at the same time and could easily configure different formatters on initialisation.

In terms of linter / formatter config, again some of this could be passed in the initializationOptions but we already support reading config from setup.cfg, tox.ini files etc. that are available in the workspace. Unfortunately this is currently done manually instead of relying on the tools' built-in config parsing meaning results may vary. An improvement here might be to shell out to pycodestyle / pyflakes / any other linter setting the working directory to the workspace root and then parsing stdout.

from python-language-server.

gatesn avatar gatesn commented on May 28, 2024

I'm going to close out this issue since its a bit generic and vague. I think there are a couple of issues up for configuration of providers and for performance. Feel free to open any other issues separately if not covered by those two. Thanks!

from python-language-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.