Giter Site home page Giter Site logo

Comments (2)

nmiyake avatar nmiyake commented on May 30, 2024

I'm not sure about this -- I think that having the health status information at INFO can be helpful. The logs being noisy also doesn't seem like a major concern given that filtering out log events/lines is not too hard. Although I don't feel super strongly about this, my gut feeling is that I have a preference for the current behavior over the proposed change.

@bmoylan do you have any thoughts/insight here?

from witchcraft-go-server.

najork avatar najork commented on May 30, 2024

After thinking about this a bit more, I don't think it makes sense to have it emit the same log line at different levels depending on the health state, and I believe that it's valuable to emit changes to the check contents for unhealthy states. I'm going to close this out since I believe the current behavior handles this properly.

from witchcraft-go-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.