Giter Site home page Giter Site logo

Comments (7)

edydfang avatar edydfang commented on June 6, 2024

take

from pandas.

jomorodi avatar jomorodi commented on June 6, 2024

the applymap_index method has a future warning and not a deprecation warning in it can you please provide a little detail about what kind of test is expected e.g. should the test pass if it has a future warning inside it? Br

from pandas.

edydfang avatar edydfang commented on June 6, 2024

styler.applymap_index(func, axis="index")

@natmokval I found the test for it in older verion branch. Do you have any idea why those tests were removed?

from pandas.

natmokval avatar natmokval commented on June 6, 2024

@natmokval I found the test for it in older verion branch. Do you have any idea why those tests were removed?

@edydfang could you please give a hash identifier of the commit, so I can check

from pandas.

natmokval avatar natmokval commented on June 6, 2024

the applymap_index method has a future warning and not a deprecation warning in it can you please provide a little detail about what kind of test is expected e.g. should the test pass if it has a future warning inside it? Br

To clarify: the method applymap_index is deprecated (one can see it in warnings message) and the type of the Warning is FutureWarning
If you grep for FutureWarning in pandas/tests/ you'll see a lot of tests for FutureWarning. You can you use them as examples.

from pandas.

edydfang avatar edydfang commented on June 6, 2024

@natmokval I found the test for it in older verion branch. Do you have any idea why those tests were removed?

@edydfang could you please give a hash identifier of the commit, so I can check

#52708

looks like in this PR the old test for applymap_index was replaced with the test for new API.

Maybe I misunderstood the intent here: Are we testing the functional behavior of the function or are we testing the warning?

Looks like @jomorodi wrote a test that is testing the warning behavior. #56822

from pandas.

natmokval avatar natmokval commented on June 6, 2024

Maybe I misunderstood the intent here: Are we testing the functional behavior of the function or are we testing the warning?

The task here is to write a test for FutureWarning. In this case it means that the test should contain the message "Styler.applymap_index has been deprecated. Use Styler.map_index instead."

from pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.