Giter Site home page Giter Site logo

Comments (2)

rohanjain101 avatar rohanjain101 commented on June 29, 2024

I believe behavior was changed in #55568 but is the 2.2.0 result not the expected result? Since the documentation states that the fill value should only be used when one side is missing, in this case, since the left series is a nullable dtype, should np.nan not be treated as a missing value? I would have thought that even for nullable types, since nan is converted to NA in construction:

>>> pd.Series([np.nan], dtype="Float64")
0    <NA>
dtype: Float64
>>>

In this example, since both left and right are missing values, fill value should not do a replacement.

from pandas.

sfc-gh-jkew avatar sfc-gh-jkew commented on June 29, 2024

The current behavior makes sense (only fill when one side is missing) because it follows the docs, but I can see why this would be confusing. It's entirely reasonable to assume without a close reading that fill_value might fill both sides as opposed to only one side when there's an np.nan.

from pandas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.