ENH: pd.series.sample when n > len

[marctorsoc]

ENH: pd.series.sample when n > len

[lithomas1]

IIRC the error comes from numpy.

This is what I get

  File "/Users/thomasli/pandas/pandas/core/sample.py", line 153, in sample
    return random_state.choice(obj_len, size=size, replace=replace, p=weights).astype(
  File "numpy/random/mtrand.pyx", line 1001, in numpy.random.mtrand.RandomState.choice
ValueError: Cannot take a larger sample than population when 'replace=False

In that case, in my opinion, I think it's probably best for you to add an if check in your code before the call to sample to restrict the sample size to the length of the dataframe.

[marctorsoc]

yeah, for the cases of production code, of course I can add an if. But when exploring on a notebook with constructions like this (imagine this is not static code, but iterating with many filters on it):

(
         df
         .loc[lambda df: df.price.gt(10)]
         .loc[lambda df: df.date.lt("2023-04")
         .sample(10)
)

Here you cannot do an if before because there's no before. I happen to do this very very often. I guess one solution would be ok, create a pipe and do

(
         df
         .loc[lambda df: df.price.gt(10)]
         .loc[lambda df: df.date.lt("2023-04")
         .pipe(sample_pipe, n=10)
)

containing the if... but I continue thinking that pandas should support my use case 🤷‍♂️