Comments (4)
Okay, thanks for the hint! Hm, I suppose I would add a config option to specify a git-merge-base
that β when present β automatically activates the diff
mode of credo
. Will be starting working on it this week and tell you when you can try it out.
from vscode-elixir-credo.
Hi! Sorry for answering this late. I've had much on my plate lately and I overlooked the notification for this issue within all dependabot alerts π
Seems like a nice addition to Credo overall. So what would be your suggestion on how to display the new functionality?
A command or a setting to toggle the behavior to default or to the new diff behavior? And it would make sense to only show the new
issues of the diff output command right?
I'm currently not sure what yields the best user experience, open to suggestions!
from vscode-elixir-credo.
Hey no worries! Ideally I wouldn't have to do anything if that's possible. Right now I'm using an alias to make mix credo diff ...
the default when running credo. Here's an example:
defp aliases do
[
credo: ["credo diff --from-git-merge-base origin/dev"],
...
]
end
The problem though is that I've had to comment this out because it causes the vscode extension to fail because the new output format is different than what's expected.
And yes, ideally the extension would only show new issues from the diff output command and not all issues.
from vscode-elixir-credo.
Published in version 0.8.0. π
You can now specify in the settings whether to enable the diff mode or not with "elixir.credo.diffMode.enabled": true | false
and a custom merge base with "elixir.credo.diffMode.mergeBase": "feat-01"
(default merge base is "main"
).
Let me know what you think!
from vscode-elixir-credo.
Related Issues (20)
- Add support for project subdirectories HOT 18
- ".credo.exs file does not exist. Ignoring..." (Windows 10) HOT 4
- Error mix credo returned empty output HOT 7
- Linter doesn't show anything in umbrella application on windows 10 HOT 12
- Credo.Check.Refactor.ModuleDependencies breaks analysis HOT 1
- After saving in vscode with this extension enabled, `recompile` in IEx session does not work HOT 2
- ".credo.exs file does not exist. Ignoring..." (warning) HOT 5
- Tag filter options HOT 3
- Doesn't find the right root folder on multi-apps projects HOT 2
- Add a option to only run credo if mix.exs exists HOT 2
- Add config option to disable notification prompts regarding error parsing output
- Can't work with credo v1.6.7 HOT 2
- Extension errors when CMD/CTRL+hovering symbols from other files HOT 1
- Add option to re-lint as a vscode command and not on save
- β.credo.exs file does not existβ in Umbrella project
- β.credo.exs file does not existβ in project located in sub directory
- Pass filename to `--read-from-stdin` option to fix `credo` inconsistency HOT 2
- Wrong errors reported in VSCode HOT 3
- Add support for multiple default .credo.exs locations HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vscode-elixir-credo.