Giter Site home page Giter Site logo

Comments (7)

CC007 avatar CC007 commented on July 1, 2024 1

My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?

If those pose a problem, maybe modules could be added more explicitly

I thought about it and it shouldn't matter. Thinking about it, not specifying a module when compiling @Inline and @Classpath will cause it to be treated as pre-JDK9 code which is fine.

The only concern is if they're compiling a module-info with that. However I believe that to be rare enough of an edge case that I won't bother with it.

Well... I was debating using that, since I will eventually need to test my @NotNullByDefault and @NullableByDefault annotations for modules. It would be hard to test both of those using @Introspect and I don't even know how I would even target those using that annotation, so I think that I'm going to need @Inline for those tests.

from elementary.

CC007 avatar CC007 commented on July 1, 2024

What happens if the current module isn't named (aka a project without module-info.java), but it does rely on classes inside a named module? How does that behave and do any changes need to be made to support that?

from elementary.

Pante avatar Pante commented on July 1, 2024

What happens if the current module isn't named (aka a project without module-info.java), but it does rely on classes inside a named module? How does that behave and do any changes need to be made to support that?

From my testing, the current set-up already handles non-module code calling module code. The classes will be available on the class-path. The only case that’s not currently supported is module code to module code.

from elementary.

Pante avatar Pante commented on July 1, 2024

My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?

from elementary.

CC007 avatar CC007 commented on July 1, 2024

My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?

If those pose a problem, maybe modules could be added more explicitly

from elementary.

Pante avatar Pante commented on July 1, 2024

My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?

If those pose a problem, maybe modules could be added more explicitly

I thought about it and it shouldn't matter. Thinking about it, not specifying a module when compiling @Inline and @Classpath will cause it to be treated as pre-JDK9 code which is fine.

The only concern is if they're compiling a module-info with that. However I believe that to be rare enough of an edge case that I won't bother with it.

from elementary.

Pante avatar Pante commented on July 1, 2024

I think the issue in general is that there's no good way to retrieve the class information from an inline source since it's not yet compiled. I'm honestly not sure how to handle such a use-case.

from elementary.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.