Comments (7)
My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?
If those pose a problem, maybe modules could be added more explicitly
I thought about it and it shouldn't matter. Thinking about it, not specifying a module when compiling
@Inline
and@Classpath
will cause it to be treated as pre-JDK9 code which is fine.The only concern is if they're compiling a
module-info
with that. However I believe that to be rare enough of an edge case that I won't bother with it.
Well... I was debating using that, since I will eventually need to test my @NotNullByDefault
and @NullableByDefault
annotations for modules. It would be hard to test both of those using @Introspect
and I don't even know how I would even target those using that annotation, so I think that I'm going to need @Inline
for those tests.
from elementary.
What happens if the current module isn't named (aka a project without module-info.java), but it does rely on classes inside a named module? How does that behave and do any changes need to be made to support that?
from elementary.
What happens if the current module isn't named (aka a project without module-info.java), but it does rely on classes inside a named module? How does that behave and do any changes need to be made to support that?
From my testing, the current set-up already handles non-module code calling module code. The classes will be available on the class-path. The only case that’s not currently supported is module code to module code.
from elementary.
My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?
from elementary.
My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?
If those pose a problem, maybe modules could be added more explicitly
from elementary.
My main concern is how we’re going to detect modules for @inline and @classpath. Or is it even necessary to do so in those cases?
If those pose a problem, maybe modules could be added more explicitly
I thought about it and it shouldn't matter. Thinking about it, not specifying a module when compiling @Inline
and @Classpath
will cause it to be treated as pre-JDK9 code which is fine.
The only concern is if they're compiling a module-info
with that. However I believe that to be rare enough of an edge case that I won't bother with it.
from elementary.
I think the issue in general is that there's no good way to retrieve the class information from an inline source since it's not yet compiled. I'm honestly not sure how to handle such a use-case.
from elementary.
Related Issues (14)
- Your .dependabot/config.yml contained invalid details HOT 1
- [BUG] Repo missing in elementary/README.md HOT 9
- [FEATURE REQUEST] Rename @Case to something better HOT 36
- [BUG] Cannot use source with intentional compile errors for ToolsExtension HOT 10
- [FEATURE REQUEST] First-class module support in JUnit extensions HOT 7
- [BUG] `MemoryFileManager ` does not handle modules correctly
- [FEATURE REQUEST] Better support for parameterized tests HOT 1
- [BUG] Modules don't compile HOT 1
- Deploy artifacts to maven central HOT 12
- Dependency Dashboard
- [FEATURE REQUEST] Auto-format pull requests
- [BUG] com.karuslabs:satisfactory 1.1.3 is not available HOT 2
- Missing page "Why java 11?" HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elementary.