Giter Site home page Giter Site logo

Comments (5)

cburroughs avatar cburroughs commented on June 20, 2024 1

A default of False in 2.20 and then True in 2.21 to de-risk 2.20 makes sense to me.

Pants is already pretty chatty so I do lean towards True in 2.21 even if every single case isn't squashed. This issue with typing_extensions is "probably fine" and could trivially be worked around by futzing with the pants internal lockfiles, but the same warning could be telling a user something closer "Your code is broken!" and I don't like swallowing the underlying tool trying to tell them that.

from pants.

cburroughs avatar cburroughs commented on June 20, 2024 1

Although now that I've thought through that a little more, we probably should keep it enabled for Pants itself (in pants.toml) so we keep surfacing new cases as dogfood.

from pants.

huonw avatar huonw commented on June 20, 2024

Good catch!

I would think it'd be good not to ship this and #20577 in a stable release, potentially we should have the new option default to False for 2.20.x (and adjust the docs to indicate that there's a few "spurious" issues)?

This would relieve the pressure of needing to land potentially-broad changes to fix the underlying issues (which we presumably should fix) to unblock 2.20.0.

Thoughts?

from pants.

huonw avatar huonw commented on June 20, 2024

(Chucked up #20590 with that idea, in case we want to go with it.)

from pants.

huonw avatar huonw commented on June 20, 2024

Removing this from the 2.20.x milestone, since we landed #20593 as a stop-gap to reduce severity in 2.20.0

from pants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.