Comments (4)
I can definitely ship this; the question becomes, what happens for folks who are already using the existing skip_ruff
field? I think a sane default might be to have skip_ruff
be equivalent to skip_ruff_check
in the new world.
from pants.
Yeah, that sounds sensible. Just to convince myself some more, drawing an analogy to the backend changes, pants.backend.experimental.python.lint.ruff
was deprecated in favour of pants.backend.experimental.python.lint.ruff.check
and thus it'd make sense that its associated skip_ruff
field is deprecated in favour of skip_ruff_check
. Good thinking!
from pants.
why not have skip_ruff
be the equiv. of having skip_ruff_check
and skip_ruff_format
?
To me, it feels like the shorter name could be the parent of both of them, that is skip_ruff
as a parent skip field to skip all ruff stuff.. current and future features that may be added to it.
from pants.
why not have skip_ruff be the equiv. of having skip_ruff_check and skip_ruff_format?
That's basically what it does now 😄
I had a go at this last night and I think it's probably going to be more complicated than expected because of the way that the skip fields work. I'll still try to get it in before 2.20 releases but we may have to push it out to the next release instead.
from pants.
Related Issues (20)
- Run tests on MacOS ARM in CI HOT 3
- Use of FaaS `runtime=...` when there's no built-in complete platform silently falls back to `--platform=...` and thus often has confusing broken builds
- Support "built-in" selection of ARM architecture for Python AWS Lambda targets
- module_mapping failing with pants > 2.19 for Cv2 HOT 5
- Remove hardcoded `platform` in `execution_environment`
- Invalid/unused `pants: ...` directives like `no-infer-dep` are silently ignored HOT 3
- Corepack package manager installation is not captured
- Pants log level stuck as DEBUG HOT 6
- Generate lockfiles doesn't work with an empty requirements file HOT 4
- Create a Github CI action that automatically updates example repos on stable release
- Folders denoted as `append_only_caches` not accessible in `output_digest` HOT 1
- Add "Common tasks" contributing docs
- [Call-by-name] Investigate using concrete syntax trees for migration code
- [Call-by-name] pathlib subpath exception when using migration outside of main pants repo
- Files encompassed as part of `output_directories=(".",)` can be hard links without write permissions
- Python provider not used for `pants package` of `pex_binary` target HOT 1
- Install failed for pants plugin HOT 4
- "list" options having bad error messages when used like a "dict". HOT 1
- Support testing a `python_distribution` HOT 1
- Error installing on alpine HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pants.