Comments (4)
I can definitely ship this; the question becomes, what happens for folks who are already using the existing skip_ruff
field? I think a sane default might be to have skip_ruff
be equivalent to skip_ruff_check
in the new world.
from pants.
Yeah, that sounds sensible. Just to convince myself some more, drawing an analogy to the backend changes, pants.backend.experimental.python.lint.ruff
was deprecated in favour of pants.backend.experimental.python.lint.ruff.check
and thus it'd make sense that its associated skip_ruff
field is deprecated in favour of skip_ruff_check
. Good thinking!
from pants.
why not have skip_ruff
be the equiv. of having skip_ruff_check
and skip_ruff_format
?
To me, it feels like the shorter name could be the parent of both of them, that is skip_ruff
as a parent skip field to skip all ruff stuff.. current and future features that may be added to it.
from pants.
why not have skip_ruff be the equiv. of having skip_ruff_check and skip_ruff_format?
That's basically what it does now 😄
I had a go at this last night and I think it's probably going to be more complicated than expected because of the way that the skip fields work. I'll still try to get it in before 2.20 releases but we may have to push it out to the next release instead.
from pants.
Related Issues (20)
- Allow extra env vars during nodejs package manager installation
- `pex_binary` `entry_point` is silently ignored if in different resolve HOT 2
- `__defaults__` should apply also for generated targets
- Allow multiple `cache_from` entries for `docker_image`
- JVM: Pants/Nailgun and future JDKs releases (after version 17) HOT 1
- use_buildx on macos results in failure to package/build the image. HOT 9
- generate go_asm.h in an object directory (Internal)
- `pants help-all` isn't deterministic HOT 1
- python requirement from private package feed using injected PAT HOT 4
- Inability to pass env vars to native engine breaks AWS authentication for assumed roles HOT 11
- Deprecated fields not preserved for target generators
- Virtual environment with symlinked interpreter in pants-managed project crashes Pants HOT 2
- Docker: base image build arg detection does not support parametrized targets
- Pants should release it's lock on run targets HOT 4
- fetching python dependencies from a private repository (index) in Artifact Registry HOT 2
- Broken link on docs site home page HOT 4
- Backport #20587 to 2.19.x to fix `Exec format error` when running Pants on Linux HOT 3
- system_binary not finding binary in path HOT 5
- java.util.zip.ZipException: attempt to write past end of STORED entry HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pants.