Giter Site home page Giter Site logo

Comments (4)

krishnan-chandra avatar krishnan-chandra commented on June 16, 2024

I can definitely ship this; the question becomes, what happens for folks who are already using the existing skip_ruff field? I think a sane default might be to have skip_ruff be equivalent to skip_ruff_check in the new world.

from pants.

huonw avatar huonw commented on June 16, 2024

Yeah, that sounds sensible. Just to convince myself some more, drawing an analogy to the backend changes, pants.backend.experimental.python.lint.ruff was deprecated in favour of pants.backend.experimental.python.lint.ruff.check and thus it'd make sense that its associated skip_ruff field is deprecated in favour of skip_ruff_check. Good thinking!

from pants.

kaos avatar kaos commented on June 16, 2024

why not have skip_ruff be the equiv. of having skip_ruff_check and skip_ruff_format?

To me, it feels like the shorter name could be the parent of both of them, that is skip_ruff as a parent skip field to skip all ruff stuff.. current and future features that may be added to it.

from pants.

krishnan-chandra avatar krishnan-chandra commented on June 16, 2024

why not have skip_ruff be the equiv. of having skip_ruff_check and skip_ruff_format?

That's basically what it does now 😄

I had a go at this last night and I think it's probably going to be more complicated than expected because of the way that the skip fields work. I'll still try to get it in before 2.20 releases but we may have to push it out to the next release instead.

from pants.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.