Rust options parser fails to parse 1 as float, different to legacy parser

[huonw]

Rust options parser fails to parse 1 as float, different to legacy parser

[huonw]

Ah, this error is likely coming from code that calls:

pants/src/rust/engine/options/src/config.rs

Lines 191 to 202 in 13ef2ec

	impl FromValue for f64 {
	fn from_value(value: &Value) -> Result<f64, ValueConversionError> {
	if let Some(float) = value.as_float() {
	Ok(float)
	} else {
	Err(ValueConversionError {
	expected_type: "float",
	given_value: value,
	})
	}
	}
	}

which is

pants/src/rust/engine/options/src/config.rs

Lines 504 to 506 in 13ef2ec

	fn get_float(&self, id: &OptionId) -> Result<Option<f64>, String> {
	f64::from_config(self, id)
	}

That's an implementation that overrides the default implementation of OptionsSource::get_float, and that default is what has the int fallback. That is, when reading a toml config file, there's no int fallback behaviour for floats.

Easy enough to add to f64::from_value.

[huonw]

That being the cause is reaffirmed by passing the option as an arg or an env var both working:

pants --pantsd-timeout-when-multiple-invocations=1 version
PANTS_PANTSD_TIMEOUT_WHEN_MULTIPLE_INVOCATIONS=1 pants version