BUG: Transposing photo causes exception

[thomas-olsson]

BUG: Transposing photo causes exception

[paolobenve]

The only thing I can think of is to manage the exception and avoid the error, pushed fix in development master branch,

Do not use development branch, it's still unstable!

the image is not transposed

Perhaps it would be better to consider the image unreadable?

please test it

[paolobenve]

Is this bug related to python-pillow/Pillow#1510 ?

[thomas-olsson]

I did the same workaround locally, so at least we think alike :-).

Tested the fix. It works as expected.

Might be related to the bug you refer to, but I am not skilled enough to judge... seems the EOF character is 4654, not FF09, it the photo which throws the exception. However, there are other photos in my album with EOF token 4654 and with an orientation which would cause transpose the photos in myphotoshare. I have not confirmed that the transpose code is actually executed though, but reviewing the code and files make if plausible.

[paolobenve]

ok, but what does it happen with the panorama? is it shown in a weird mode?

[thomas-olsson]

I created it from multiple photos I took. I used Hugin (http://hugin.sourceforge.net/) to stich the photos together. The only weirdness is that it is extremely wide (23392x1600). The stich photo (which is the one causing the error) shows fine in any photo viewing software. With your latest patch, the photo shows up ok in myphotoshare, but upside-down, as it is not transposed.

Attaching the resulting file from myphotoshare.

[paolobenve]

ok

But will be there a way to get it correctly?

[thomas-olsson]

Googling a bit and found that "invalid SOS parameter for sequential JPEG" is not that uncommon.

E.g. http://www.imagemagick.org/discourse-server/viewtopic.php?t=30320

Some examples for how others have addressed this:
owncloud/core#21873
https://stackoverflow.com/questions/35337709/invalid-sos-parameters-for-sequential-jpeg

Personally, I have just this one photo with this problem. So for me, no need to fix this more than catching the exception as done in the latest patch from Paulo. However, if this is a more frequent problem, then perhaps finding a proper solution is more important.