Comments (4)
Hi @paperboi , Sure, I can check out the issue further in the weekend and get back.
I do want to add that I had only tested with firefox, for that is the main browser that I use, and the fix did seem to resolve the issue for me. If there are any specific details on how you are testing, can you please share them as might provide more information on the steps to reproduce and the cases I might be missing to check ?
from kindle2notion.
Hi @paperboi , Sure, I can check out the issue further in the weekend and get back.
I do want to add that I had only tested with firefox, for that is the main browser that I use, and the fix did seem to resolve the issue for me. If there are any specific details on how you are testing, can you please share them as might provide more information on the steps to reproduce and the cases I might be missing to check ?
Got it working finally! Had to make some considerations in the code to fetch from any response JSON objects with an imageLinks
property than just the first responses'. Books with multiple editions may have missing covers or multiple covers and the current code would only check whether the first response JSON object would have a thumbnail. Wrote a for loop to go through all possible results and fetch the first one with a thumbnail listed.
Implemented the solution in the latest release. Thanks for contributing to the repo!
from kindle2notion.
Glad to hear that, that's definately a better approach to handle adding missing book covers. Cheers!
from kindle2notion.
For some reason, this keeps happening on Firefox. Your solution worked for Chrome and Microsoft Edge (I assume it must be the same for all other Chromium browsers).
Wonder what could be the reason behind this. Thanks for your contribution tho @guptaanmol184. Can you please look into this too?
from kindle2notion.
Related Issues (20)
- raise HTTPError( requests.exceptions.HTTPError: Invalid input. HOT 9
- I keep getting the following IndexError: list index out of range HOT 2
- requests.exceptions.HTTPError: Invalid input. HOT 2
- Can't install kindle2notion. setuptools not available in the build environment. HOT 5
- I keep getting this error "raise HTTPError( requests.exceptions.HTTPError: Something went wrong." HOT 1
- "from more_itertools import grouper" needs to commented on the packages. HOT 1
- ENHANCEMENT: Create and maintain JSON object of books and clippings to reduce API calls and update only those clippings that are modified each time. HOT 1
- APIResponseError: API token is invalid HOT 3
- Update docs to reflect the new Notion API integration token setup
- AttributeError: 'NoneType' object has no attribute 'strftime' HOT 4
- Unable to sync clippings with many highlights HOT 1
- TypeError: issubclass() arg 1 must be a class HOT 2
- 'ascii' codec can't encode character '\u2019' in position 217: ordinal not in range(128) HOT 1
- Error when trying to export. HOT 4
- ValueError: invalid literal for int() with base 10: '60.0' HOT 1
- Client error '400 Bad Request' with body.children[0].paragraph.rich_text[16].text.content.length should be ≤ `2000`, instead was `2001`.
- Unsure if My input format is correct: 401 Client Error HOT 1
- Need to update the documentation about how to share database with integration
- Add support for exported notes form Kindle app
- ValueError: time data '' does not match format '%A, %d %B %Y %I:%M:%S %p' HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kindle2notion.