Delete user invitation links after they are used

[papercups-io]

Delete user invitation links after they are used

[rlanga]

Definitely sounds like a great idea! I could modify my code for this

[n1arash]

Hi,
I want to send a PR on this.
Isn't this better that we add a boolean flag for user invite and keep the record that will invalidate the invitation link and save the record in the database for future use like analytics or showing past invitations?

[reichert621]

hmm yeah @n1arash, good point -- maybe we can add a flag like you suggested or just update the expires_at field to the current time, and then make sure we check against expiration before allowing the invitation to be used? what do you think?

[n1arash]

I think updating the expires_at field can do the job, and also we can send an appropriate error to the frontend if a user used the link again with a 403 status header.

[reichert621]

sounds perfect @n1arash

[rlanga]

Hi,
I've done some sample modifications that delete the invite token after user creation is successful. I also split out the logic for cases when an invite token is included in the params and when it isn't. I think logic for #59 can be added to the create method for invite tokens. It could be modified to set the boolean flag to the invites as @n1arash mentioned.

Please have a look at the commit on my repo fork.

[reichert621]

@rlanga nice! your commit definitely looks like it solves the original issue, and i love the refactoring + test coverage 😁

i think what @n1arash mentioned might be a good idea though — instead of deleting the invite after it's used, it would be helpful to keep it around so we can have a record of which invites have been used vs not. so rather than deleting, we could set up a method like

ChatApi.UserInvitations.mark_user_invitation_expired(invite)

or something like that, and then throw a helpful error if someone tries to sign up with an expired invite. what do you think?

[reichert621]

thanks @rlanga!

[reichert621]

btw @rlanga and @n1arash if you ever want to chat with us directly about this, feel free to join our slack or discord channels https://github.com/papercups-io/papercups#get-in-touch 😄

[reichert621]

handled in #81