CrystalProc ignores Crystal-side type conversions

[papierkorb]

CrystalProc ignores Crystal-side type conversions

[HertzDevil]

Looks like VirtualOverride is already doing a similar thing, for example:

module Qt
  class SpinBox < AbstractSpinBox
    def initialize(parent : Widget? = nil)
      # ...
      jump_table = Binding::BgJumptable_SpinBox.new(
        # ...
        bg_QSpinBox_valueFromText_const_QString_R: BindgenHelper.wrap_proc(
          {% if forwarded.includes?("value_from_text") %}
            Proc(CrystalString, Int32).new{|text| self.value_from_text(Qt::Converter::QString.unwrap(text)) }
          {% else %}
            nil
          {% end %}
        ),

It is also the only place in Bindgen's source code that uses wrap_proc, as CrystalProc's is hardcoded in builtin_types.yml...?

bindgen/builtin_types.yml

Lines 100 to 107 in 3a1543e

	CrystalProc:
	wrapper_type: Proc
	binding_type: CrystalProc
	kind: Struct
	builtin: true # We don't want a binding alias for this.
	pass_by: Value
	wrapper_pass_by: Value
	from_crystal: "BindgenHelper.wrap_proc(%)"

[docelic]

@Papierkorb could you please comment on this one as well, when you get a chance? Thanks!

[Papierkorb]

Yeah that's a bug. The signals, or rather block arguments, should use the same conversion tactic.

[docelic]

@HertzDevil do you think you could attempt producing a patch for this?