Qt 5.14 errors

[papierkorb]

Qt 5.14 errors

[docelic]

Hey how about we just rename newer and older to newer_or and older_or before this gets used in practice?
This small rename could better capture the inclusion of equal (">="/"<="), and also it would not clash with possible future addition of real newer/older which does not imply the "=".

[ZaWertun]

@ZaWertun Yeah that would be the ideal addition. The syntax I chose is X_(is|isnt|match)_Y to be as readable as possible (Without the reader scouring some docs on that syntax). Maybe there's a syntax possible in that vein like X_olderthan_Y.
Why it's not there yet? I guess I didn't need it, can't remember really.

Maybe just call it newer / older? (newer_or_equals / older_or_equals)

[ZaWertun]

To fix this you has to modify config/enums.yml, like in this commit that fixes build for Qt-5.13:
ZaWertun@87b1471.
See that I've added mappings for QGradient::Preset and QAbstractSpinBox::StepType.

[ZaWertun]

I'll try to fix this and make PR.

[docelic]

Hey, sure, just listed it here due to a question in #20. I already added some, but will wait for your PR then not to duplicate effort. Thanks!

[docelic]

@ZaWertun speaking of which, are you aware of a way to add entries depending on version? From what I see here, once we add e.g. new enum entries, older versions no longer build, erroring out with:

Enum doesn't have any constants at <enum name>

[ZaWertun]

@ZaWertun speaking of which, are you aware of a way to add entries depending on version? From what I see here, once we add e.g. new enum entries, older versions no longer build, erroring out with:

Enum doesn't have any constants at <enum name>

Didn't think about it. I think we need some enum mappings defined only in Qt >= 5.13 for example.
Could it be done in current bindgen version?

[ZaWertun]

@ZaWertun speaking of which, are you aware of a way to add entries depending on version? From what I see here, once we add e.g. new enum entries, older versions no longer build, erroring out with:

Enum doesn't have any constants at <enum name>

Or maybe that check is wrong...

[docelic]

I think we need some enum mappings defined only in Qt >= 5.13 for example.
Could it be done in current bindgen version?

I did a quick search and didn't find an example of it. It seems that if_* can only compare against strings and regexes.
I also wonder how Stefan was able to generate bindings for those 4 or 5 Qt versions without needing this feature.

[ZaWertun]

I think we need some enum mappings defined only in Qt >= 5.13 for example.
Could it be done in current bindgen version?

I did a quick search and didn't find an example of it. It seems that if_* can only compare against strings and regexes.
I also wonder how Stefan was able to generate bindings for those 4 or 5 Qt versions without needing this feature.

Maybe we need something like this conditions syntax in YML files for bindgen:

• version_gte - version >= given (string param must be parsed with Bindgen::FindPath::GenericVersion);
• version_lte - version <= given;
  Maybe same for version_gt (>) + version_lt (<).

[Papierkorb]

@ZaWertun Yeah that would be the ideal addition. The syntax I chose is X_(is|isnt|match)_Y to be as readable as possible (Without the reader scouring some docs on that syntax). Maybe there's a syntax possible in that vein like X_olderthan_Y.
Why it's not there yet? I guess I didn't need it, can't remember really.

[ZaWertun]

Hey how about we just rename newer and older to newer_or and older_or before this gets used in practice?
This small rename could better capture the inclusion of equal (">="/"<="), and also it would not clash with possible future addition of real newer/older which does not imply the "=".

Looks good.