Giter Site home page Giter Site logo

Comments (4)

fgimenez avatar fgimenez commented on July 23, 2024 1

@fgimenez started a PR demonstrating the fix, I just haven't figured out how to re-build the Solidity in this repo yet (i tweaked the function signature and need the updated abi to make the sol! macro work)

yep, you can rebuild the artifacts with make build-eip3074-bytecode, I'll open a PR to include this in the README

from alphanet.

fgimenez avatar fgimenez commented on July 23, 2024

@anna-carroll thanks for raising this! you are right, the contracts here are used only in the integration tests, not meant to be deployed. in any case ideas to fix the issue are very welcome :)

from alphanet.

anna-carroll avatar anna-carroll commented on July 23, 2024

@fgimenez started a PR demonstrating the fix, I just haven't figured out how to re-build the Solidity in this repo yet (i tweaked the function signature and need the updated abi to make the sol! macro work)

from alphanet.

anna-carroll avatar anna-carroll commented on July 23, 2024

alternative uglier solution would be to leave the function signature the same & add

        require(commit == keccak256(abi.encode(to, data), "Invalid commit");

but nevertheless, would like to build & run tests to validate the fix 😅

from alphanet.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.