Possible credentials leak

[paragonie]

Possible credentials leak

[colshrapnel]

I am not very good in maintaining libraries, but technically - yeah, it would do.

[paragonie-scott]

This sounds like a duplicate of #102.

But that's only a workaround and I think it would be better to change the Factory::create() method's signature.

This is sensible, but would require a major version bump, due to a BC break.

Would adding a fromArray() method and releasing a new minor version suffice?

[colshrapnel]

Added #106
Not sure if it's the best way but at least it makes the transition most simple - just square braces have to be added around the list of parameters, ie

$db = Factory::create($dsn,$username,$password); => $db = Factory::fromArray([$dsn,$username,$password]);

[paragonie-scott]

Your strategy is precisely what I was going to do. :)