Version 2.0.0

[paragonie]

Version 2.0.0

[SignpostMarv]

I was wondering if this should throw an exception/ log a warning?

$db = new EasyDB($pdo);
$db->setAttribute(\PDO::ATTR_EMULATE_PREPARES, true);

[paragonie-scott]

Yes, that would be a good idea :)

[SignpostMarv]

In that case, would the clone statement you added negate the issue of $db->getPdo()->setAttribute() bypassing EasyDB ?

[paragonie-scott]

Yes, it would. You'd have a cloned instance of the internal PDO but be unable to affect the PDO object used by EasyDB.

[SignpostMarv]

re: code style consistency commits & static analyses commits, are the tools you use available as gpg-signed binaries as with the phpunit runner ?

[paragonie-scott]

I'm actually just using PHPStorm's built in inspections, as I've found it to be as reliable as most third party tools.

[SignpostMarv]

I use Atom at home/work, although I run php-cs-fixer from cli rather than the atom package- the .editorconfig from #11 is another habit I got into so I don't break style between machines/projects.

[SignpostMarv]

I'm guessing the only benefit to automated linting on travis is to fail a pull request if someone doesn't meet your preferred coding style.

[paragonie-scott]

I prefer the @hintjens approach: Merge and fix the code style ourselves. :)

[SignpostMarv]

:)

Since we're already throwing exceptions if $string is empty or starts with a number, should we be throwing an exception in EasyDB::escapeIdentifier() if $str !== trim($string) (or $str !== $string for the even more paranoid approach)?
i.e. $str refers to something other than $string (since "foo@bar" ≠ "foobar") vs "your $string is terrible"? (possible overkill on the input paranoia there :P)

Furthermore, is it overkill to modify it further to support separator characters when quoting? i.e.

$db = new EasyDB($pdo);

 // would normally return [foobar], "foobar" or `foobar`
$tableThenField = $db->escapeIdentifier('foo.bar');

// would normally return [foobarbaz], "foobarbaz" or `foobarbaz`
$databaseThenTableThenField = $db->escapeIdentifier('foo.bar.baz');

p.s. since the linux box is currently segfaulting on php making testing a pain, I'll be off for the night- fingers crossed that the my main system works tomorrow when it comes back from repair tomorrow.

[paragonie-scott]

6c28b21

I've made separator support optional. To enable it, $edb->setAllowSeprators(true);.

[SignpostMarv]

I've found some bugs in the tests etc., will push them up later